A couple quick fixes to Popover and input styles #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 4, 2018 09:29
- Reducing size of arrow - Fixing translate transitions - Removing old/unused styles
chandlerprall
suggested changes
Jul 4, 2018
| @@ -184,14 +184,13 @@ export class EuiPopover extends Component { | |||
| popover: this.panel, | |||
| offset: 16, | |||
| arrowConfig: { | |||
| arrowWidth: 32, | |||
| arrowBuffer: 5, | |||
| arrowWidth: 24, | |||
There was a problem hiding this comment.
arrowBuffer is required, even if it's set to 0. Without it the popover won't slide over.
and slight tweak to animation timing
chandlerprall
suggested changes
Jul 4, 2018
chandlerprall
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up some popover styles
The transition was dependent on the supplied
anchorPositionbut that never got updated if the position of the popover had to be changed because of space. Now, it uses the same positioning side as the arrow to add the animation.Before
After
Fixed background transition on inputs - Fixes #968