Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract items and search from EuiInMemoryTable's ...rest prop #851

Merged
merged 2 commits into from
May 18, 2018
Merged

Extract items and search from EuiInMemoryTable's ...rest prop #851

merged 2 commits into from
May 18, 2018

Conversation

chandlerprall
Copy link
Contributor

Fixes #850 by extracting items from the rest prop instead of passing it through to EuiBasicTable. Also extracts search prop as that is meant to be consumed by EuiInMemoryTable. Added a unit test to prevent future regressions.

@chandlerprall chandlerprall requested a review from cjcenizal May 18, 2018 19:02
cjcenizal
cjcenizal approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦 LGTM. Nice catch!

@chandlerprall chandlerprall merged commit 60e1777 into elastic:master May 18, 2018
@chandlerprall chandlerprall deleted the bug/in-memory-table-rest-props branch May 18, 2018 19:10
@chandlerprall chandlerprall mentioned this pull request May 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandlerprall @cjcenizal