Creating a standard links list for EuiHeader
#804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made the following modifications to existing comps: - `EuiHeaderLogo` now accepts text (children) as well - `EuiHeaderSectionItem` can have “none” as the border but still defaults to “left”
23 tasks
…r` for dark theme
|
Think you might want some definition against your logo because they share the same font. Either up the font-weight and give it some space with a border, or possible shift sides? Concept works though.
|
|
Closing for #844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made the following modifications to existing comps:
EuiHeaderLogonow accepts text (children) as wellEuiHeaderSectionItemcan have “none” as the border but still defaults to “left”cc @thomasneirynck
Also
Fixes #801 : Adjusted coloring of active breadcrumb in
EuiHeaderfor dark theme.