-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiDataGrid toolbar control styles to Emotion (Part 2) #7997
Commits on Sep 4, 2024
-
Convert controls toolbar styles
- convert margin left to display flex instead
Configuration menu - View commit details
-
Copy full SHA for 09e19f8 - Browse repository at this point
Copy the full SHA 09e19f8View commit details -
- NOTE: possibly revert this commit when data grid borders modifiers are converted to Emotion - I'd rather handle this at the topmost `.euiDataGrid` level
Configuration menu - View commit details
-
Copy full SHA for 8bd364b - Browse repository at this point
Copy the full SHA 8bd364bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5493fa - Browse repository at this point
Copy the full SHA c5493faView commit details -
Delete
.euiDataGrid__controlScroll
CSS + Sass variable- we're going to replace this with individual per-control Emotion styles
Configuration menu - View commit details
-
Copy full SHA for d51373b - Browse repository at this point
Copy the full SHA d51373bView commit details -
Convert column selector control to Emotion
+ convert Enzyme tests to RTL + only test render snapshot on React 18 - all other tests run on react 16/17 and should more than suffice to validate that it works there + remove valid droppable area test - this one is ludicrous to try and test in a jsdom/unit test
Configuration menu - View commit details
-
Copy full SHA for 1bb2543 - Browse repository at this point
Copy the full SHA 1bb2543View commit details -
Convert sorting control to Emotion
+ reduce extra div wrapper + update datagrid enzyme tests to account for emotion wrappers
Configuration menu - View commit details
-
Copy full SHA for 19633da - Browse repository at this point
Copy the full SHA 19633daView commit details -
Convert keyboard shortcuts to Emotion
+ improve responsive styles by moving to `auto` column width
Configuration menu - View commit details
-
Copy full SHA for 0bdf395 - Browse repository at this point
Copy the full SHA 0bdf395View commit details -
Convert display selector width style
- just inline it in the component, since it's super minor + update Enzyme tests to RTL, snapshot full popover
Configuration menu - View commit details
-
Copy full SHA for 2e3b8d3 - Browse repository at this point
Copy the full SHA 2e3b8d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6036bc1 - Browse repository at this point
Copy the full SHA 6036bc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 115c9f2 - Browse repository at this point
Copy the full SHA 115c9f2View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 052965f - Browse repository at this point
Copy the full SHA 052965fView commit details