Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiDataGrid toolbar control styles to Emotion (Part 2) #7997

Merged
merged 11 commits into from
Sep 5, 2024

Commits on Sep 4, 2024

  1. Convert controls toolbar styles

    - convert margin left to display flex instead
    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    09e19f8 View commit details
    Browse the repository at this point in the history
  2. Handle grid borders style

    - NOTE: possibly revert this commit when data grid borders modifiers are converted to Emotion - I'd rather handle this at the topmost `.euiDataGrid` level
    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8bd364b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5493fa View commit details
    Browse the repository at this point in the history
  4. Delete .euiDataGrid__controlScroll CSS + Sass variable

    - we're going to replace this with individual per-control Emotion styles
    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d51373b View commit details
    Browse the repository at this point in the history
  5. Convert column selector control to Emotion

    + convert Enzyme tests to RTL
    + only test render snapshot on React 18 - all other tests run on react 16/17 and should more than suffice to validate that it works there
    + remove valid droppable area test - this one is ludicrous to try and test in a jsdom/unit test
    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1bb2543 View commit details
    Browse the repository at this point in the history
  6. Convert sorting control to Emotion

    + reduce extra div wrapper
    
    + update datagrid enzyme tests to account for emotion wrappers
    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    19633da View commit details
    Browse the repository at this point in the history
  7. Convert keyboard shortcuts to Emotion

    + improve responsive styles by moving to `auto` column width
    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0bdf395 View commit details
    Browse the repository at this point in the history
  8. Convert display selector width style

    - just inline it in the component, since it's super minor
    
    + update Enzyme tests to RTL, snapshot full popover
    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2e3b8d3 View commit details
    Browse the repository at this point in the history
  9. Delete Sass files

    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6036bc1 View commit details
    Browse the repository at this point in the history
  10. changelog

    cee-chen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    115c9f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    052965f View commit details
    Browse the repository at this point in the history