Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiFilePicker #7833

Merged
merged 17 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/7833.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**CSS-in-JS conversions**

- Converted `EuiFilePicker` to Emotion; Removed `$euiFilePickerTallHeight`
1 change: 0 additions & 1 deletion packages/eui/src/components/form/_index.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
@import 'checkbox/index';
@import 'described_form_group/index';
@import 'file_picker/index';
@import 'form';
@import 'form_control_layout/index';
@import 'form_error_text/index';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,30 @@

exports[`EuiFilePicker is rendered 1`] = `
<div
class="euiFilePicker euiFilePicker--large testClass1 testClass2 emotion-euiTestCss"
class="euiFilePicker testClass1 testClass2 emotion-euiFilePicker-euiTestCss"
>
<input
aria-describedby="generated-id-filePicker__prompt"
aria-label="aria-label"
class="euiFilePicker__input emotion-euiFilePicker__input-largeInteractive"
data-test-subj="test subject string"
type="file"
/>
<div
class="euiFilePicker__wrap"
class="euiFilePicker__prompt emotion-euiFilePicker__prompt-large"
id="generated-id-filePicker__prompt"
>
<input
aria-describedby="generated-id-filePicker__prompt"
aria-label="aria-label"
class="euiFilePicker__input"
data-test-subj="test subject string"
type="file"
<span
aria-hidden="true"
class="euiFilePicker__icon emotion-euiFilePicker__icon-large"
color="primary"
data-euiicon-type="importAction"
/>
<div
class="euiFilePicker__prompt"
id="generated-id-filePicker__prompt"
<span
class="euiFilePicker__promptText"
>
<span
aria-hidden="true"
class="euiFilePicker__icon"
color="primary"
data-euiicon-type="importAction"
/>
<div
class="euiFilePicker__promptText"
>
Select or drag and drop a file
</div>
</div>
Select or drag and drop a file
</span>
</div>
</div>
`;
212 changes: 0 additions & 212 deletions packages/eui/src/components/form/file_picker/_file_picker.scss

This file was deleted.

2 changes: 0 additions & 2 deletions packages/eui/src/components/form/file_picker/_index.scss

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,7 @@ export default meta;
type Story = StoryObj<EuiFilePickerProps>;

export const Playground: Story = {};

export const NonLargeDisplay: Story = {
args: { display: 'default' },
};
Loading
Loading