Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBetaBadge] Improved the accessibility experience of EuiBetaBadge component #7805

Merged
merged 5 commits into from
May 31, 2024
Merged

[EuiBetaBadge] Improved the accessibility experience of EuiBetaBadge component #7805

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
280bfc2
fix: [EuiTabs ][A11Y] - Using EuiBetaBadge within EuiTab
alexwizp May 31, 2024
1953c20
fix CI
alexwizp May 31, 2024
75dab22
fix CI
alexwizp May 31, 2024
9a11c59
add chanelog
alexwizp May 31, 2024
c4c1a72
[PR feedback] changelog tweak
cee-chen May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/7805.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Accessibility**

- Improved the accessibility experience of EuiBetaBadge component
cee-chen marked this conversation as resolved.
Show resolved Hide resolved
1 change: 0 additions & 1 deletion packages/eui/src/components/badge/beta_badge/__snapshots__/beta_badge.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ exports[`EuiBetaBadge props tooltip and anchorProps are rendered 1`] = `
>
<span
class="euiBetaBadge emotion-euiBetaBadge-hollow-m-baseline"
role="button"
tabindex="0"
>
Beta
Expand Down
8 changes: 1 addition & 7 deletions packages/eui/src/components/badge/beta_badge/beta_badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,13 +230,7 @@ export const EuiBetaBadge: FunctionComponent<EuiBetaBadgeProps> = ({
title={title || label}
anchorProps={anchorProps}
>
<span
tabIndex={0}
css={cssStyles}
className={classes}
role="button"
{...rest}
>
<span tabIndex={0} css={cssStyles} className={classes} {...rest}>
{icon || label}
</span>
</EuiToolTip>
Expand Down
Loading