Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFormControlLayout] Convert from class to function component #7803

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented May 30, 2024

Summary

Note

This PR merges into a feature branch.

This tech debt will allow us to more easily use hooks for Emotion styles in a future PR.

QA

General checklist

N/A, tech debt only

@cee-chen cee-chen force-pushed the emotion/form-layout-functional-component branch from 36faa96 to c6473d5 Compare May 30, 2024 16:27
@cee-chen cee-chen marked this pull request as ready for review May 30, 2024 16:55
@cee-chen cee-chen requested a review from a team as a code owner May 30, 2024 16:55
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome call to migrate to a function component! 👏 Looks nice and clean to me and seems to be working as expected ✅

I only left a small comment, I approve this PR already in case it's actually expected to not have a default value for iconsPosition anymore 🙂

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@cee-chen cee-chen merged commit 1780a0d into elastic:emotion/forms Jun 4, 2024
4 checks passed
@cee-chen cee-chen deleted the emotion/form-layout-functional-component branch June 4, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants