-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Revert removed setTimeout on EuiInputPopover scroll listener #7760
[Fix] Revert removed setTimeout on EuiInputPopover scroll listener #7760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes locally and verified it fixes kibana tests. I'm happy to get this merged when Cee's comments are addressed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for hopping on this Lene! Also, looking forward to when we can more frequently run EUI against Kibana CI to catch issues like this that only crop up in test environments 😭
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Summary
closes #7761
This PR reverts earlier changes done in this PR which remove a
setTimeout
onEuiInputPopover
's scroll listener.This change triggered flaky e2e test behaviors in Kibana (observed from version
94.3.0
).QA
Verifying fix on Kibana
gh pr checkout 7760
packages/eui
withyarn build-pack
yarn es snapshot
,yarn kbn bootstrap --no-validate && yarn start
)security_solution
test directory and run the cypress testsrule_creation/common_flows.cy.ts
to runVerifying Firefox issue around unexpectedly closing combobox panel on hover is still fixed
🔗 Issue conversation
EuiComboBox
in FirefoxEuiComboBox
for opening the popover panel