Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook] Add stories for more components (letters R-S) - Part 1 #7687

Merged
merged 13 commits into from
Apr 29, 2024
Merged

[Storybook] Add stories for more components (letters R-S) - Part 1 #7687

merged 13 commits into from
Apr 29, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Apr 16, 2024 •
edited
Loading

Summary

Relates to #7482.

This PR adds more stories for components with the letter P:

  • EuiResizableContainer
  • EuiResizablePanel
  • EuiShowFor
  • EuiSearchBar
  • EuiSearchFilters
  • EuiSpacer
  • EuiStat

QA

@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Apr 16, 2024
@mgadewoll mgadewoll marked this pull request as ready for review April 16, 2024 12:20
@mgadewoll mgadewoll requested a review from a team as a code owner April 16, 2024 12:20
@tkajtoch tkajtoch self-requested a review April 16, 2024 14:15
tkajtoch
tkajtoch reviewed Apr 16, 2024
View reviewed changes
src/components/resizable_container/resizeable_container.stories.tsx Outdated
@@ -0,0 +1,229 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed the story preview is pretty laggy when resizing the container. Have you experienced that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename resizeable_panel.stories.tsx and this file to match the directory naming? It should be resizable instead of resizeable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename resizeable_panel.stories.tsx and this file to match the directory naming? It should be resizable instead of resizeable

Woops, yes thanks for the catch!

Copy link
Contributor Author

@mgadewoll mgadewoll Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed the story preview is pretty laggy when resizing the container. Have you experienced that?

Yes, also for me it's a bit laggy. I'm wondering if that might be related to storybook running in iframes?

mgadewoll added 11 commits April 26, 2024 13:44
@mgadewoll
docs(storybook): add stories for EuiResizableContainer and Panel
a7bf2ef
@mgadewoll
refactor(EuiFieldSearch): add onClear prop
d550554
@mgadewoll
docs(storybook): add EuiSearchBar and EuiSearchBarFilters stories
a097312
@mgadewoll
docs(storybook): add stories for EuiShowFor, EuiSpacer and EuiStat
922b382
@mgadewoll
docs(storybook): cleanup and improvements
0472493
@mgadewoll
docs(storybook): ensure proper Query types are passed as state
abddb1a
@mgadewoll
docs(storybook): rename files to match directory name
07972e7
@mgadewoll
docs(storybook): add additional sizes as default to ensure more visib…
ed69f23 
…ility in the preview
@mgadewoll
docs(storybook): use faker.seed to generate stable data
9a36445
@mgadewoll
docs(storybook): PR feeback
99ea783 
- update initialSize of EuiResizablePanel story

- remove background-color for spacer story element
@mgadewoll
docs(storybook): simplify EuiSearchBar story
48ef4f7
@mgadewoll mgadewoll force-pushed the storybook/7482-stories-r-s branch from edbc7e6 to 48ef4f7 Compare April 26, 2024 12:08
cee-chen
cee-chen approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for your consistently awesome work on our stories Lene!!

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll merged commit 9281590 into elastic:main Apr 29, 2024
7 checks passed
@mgadewoll mgadewoll deleted the storybook/7482-stories-r-s branch April 29, 2024 09:27
mgadewoll added a commit to mgadewoll/eui that referenced this pull request May 3, 2024
@mgadewoll
[Storybook] Add stories for more components (letters R-S) - Part 1 (e…
e441fe8 
…lastic#7687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkajtoch tkajtoch tkajtoch left review comments

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mgadewoll @kibanamachine @elasticmachine @cee-chen @tkajtoch