-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiRange]: Add conditional aria-valuetext
when ticks
prop is passed
#7675
Merged
1Copenut
merged 20 commits into
elastic:main
from
1Copenut:feature/range-tick-ariavaluetext
Apr 16, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b6085ce
Added aria-valuetext logic to EuiRangeSlider.
1Copenut aab49b5
Added accessibleLabel type to EuiRangeTick, logic to build aria-value…
1Copenut a8517c8
Adding aria-valuenow logic for EuiRange.
1Copenut da14962
Adding unit test logic for aria-valuenow and aria-valuetext.
1Copenut 5cc66a5
Updated EuiRange ticks doc with accessibleLabel.
1Copenut 7c155dc
Updated Tick marks docs to highlight accessibleLabel property.
1Copenut bd2275e
Linting error on target declaration.
1Copenut cb7bfe8
Added changelog for 7675.
1Copenut 20d11d6
Removing aria-valuenow attribute because it is not needed for SR anno…
1Copenut 8372187
Refactored handleAriaValueText into one ternary from two guard clauses.
1Copenut 7a2b1ca
Refactoring ternary for better readability.
1Copenut 1a1f48d
Refactored handleAriaValueText to allow string labels.
1Copenut 5ef3d4e
Updated test logic to include label typeof string.
1Copenut b8439df
Updated docs to illustrate aria-valuetext with label typeof string.
1Copenut 7b7a870
Update changelogs/upcoming/7675.md
1Copenut 08c8aa3
Update src/components/form/range/range.tsx
1Copenut 0ccc7a4
[PR feedback] tests
cee-chen fed091f
sorry Trevor!
cee-chen f3b701e
Update src-docs/src/views/range/range_example.js
1Copenut 87ea5d5
Update src/components/form/range/range.tsx
1Copenut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
**Accessibility** | ||
|
||
- Added `aria-valuetext` attributes to `EuiRange`s with tick labels for improved screen reader UX |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 Now this is an example that makes sense to me! Huzzah!