Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTable][EuiBasicTable][EuiInMemoryTable] Remove responsive prop completely in favor of responsiveBreakpoint #7633

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Mar 28, 2024

Summary

NOTE: This is going into the EuiTable Emotion conversion/cleanup feature branch.

I figured since we're already breaking/removing table props in #7632 and we're going to have to update a bunch of Kibana usages anyway, I should go ahead and just remove the responsive prop entirely that was only deprecated in #7625.

⚠️ Kibana updates needed:

Typescript will help us catch most of these, but here's a quick list from searching (~10 found instances):

QA

QA will not look entirely correct until all Sass styles have been converted to Emotion. Also, QA should have already occurred as part of #7625 / will have another pass in the final feature branch

General checklist

  • Browser QA
    • Checked in mobile
  • Docs site QA
    • Props have proper autodocs (using @default if default values are missing) and playground toggles
  • Code quality checklist - N/A
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist - N/A

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
masseyke Keith Massey
- instead of deprecating it - might as well since we're already breaking a bunch of other table props, and conversion for `={false}` usage is just a prop name change

+ update changelog section with a section specifically for DOM
Copy link

github-actions bot commented Mar 28, 2024

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

  • If this PR contains prop/API changes:
    • Search through Kibana for <EuiComponent usages (example search)
    • In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)

Sorry, something went wrong.

@cee-chen cee-chen marked this pull request as ready for review March 28, 2024 22:18
@cee-chen cee-chen requested a review from a team as a code owner March 28, 2024 22:18
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@JasonStoltz
Copy link
Member

I agree, I think the move directly to the breaking change without a lengthy deprecation here is fine. As you mentioned, we're making a bunch of other breaking changes anyway, and the level of effort here for a consumer to switch props should be low.

@cee-chen cee-chen merged commit ad457a6 into elastic:tableflip Mar 29, 2024
8 checks passed
@cee-chen cee-chen deleted the emotion/table-3.5 branch March 29, 2024 23:18
cee-chen added a commit that referenced this pull request Apr 1, 2024
…completely in favor of `responsiveBreakpoint` (#7633)
cee-chen added a commit that referenced this pull request Apr 5, 2024
…completely in favor of `responsiveBreakpoint` (#7633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants