Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook] Add stories for more components (letters M - O) - Part 1 #7596

Merged
merged 6 commits into from
Mar 22, 2024
Merged

[Storybook] Add stories for more components (letters M - O) - Part 1 #7596

merged 6 commits into from
Mar 22, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Mar 19, 2024 •
edited
Loading

Summary

relates to #7480

This PR adds stories for components related to EuiModal:

  • EuiModal
  • EuiModalFooter
  • EuiModalHeader
  • EuiModalBody
  • EuiConfirmModal
  • EuiOverlayMask

QA

@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Mar 19, 2024
@mgadewoll mgadewoll marked this pull request as ready for review March 19, 2024 17:53
@mgadewoll mgadewoll requested a review from a team as a code owner March 19, 2024 17:53
@mgadewoll
docs(storybook): PR feedback
301ab13 
- remove stateful content from stories for EuiConfirmModal and EuiOverlayMask

- add EuiModal as decorator for EuiModal sub-component stories
cee-chen
cee-chen reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor story organization requests around EuiModal - LMK if they don't make sense to you!

src/components/modal/modal.stories.tsx Show resolved Hide resolved
src/components/modal/modal.stories.tsx Outdated Show resolved Hide resolved
src/components/modal/modal.stories.tsx Outdated Show resolved Hide resolved
@mgadewoll
docs(storybook): cleanup and PR feedback
09117e5 
- simplify EuiModal initialFocus story
cee-chen
cee-chen approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Changes look terrific! Thanks for your patience with my feedback/back and forth Lene!

@mgadewoll
Copy link
Contributor Author

Thanks @cee-chen for the great feedback! ❤️

@kibanamachine
Copy link

Preview staging links for this PR:

@mgadewoll mgadewoll merged commit 1f342fa into elastic:main Mar 22, 2024
7 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll deleted the storybook/7480-stories-m-o branch March 26, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgadewoll @kibanamachine @elasticmachine @cee-chen