Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook] add stories for more components (letters I - L) #7589

Merged
merged 10 commits into from
Mar 21, 2024
Merged

[Storybook] add stories for more components (letters I - L) #7589

merged 10 commits into from
Mar 21, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Mar 18, 2024 •
edited by tkajtoch
Loading

Summary

closes #7479

This PR adds stories for the following components:

  • EuiI18n (specific stories instead of playground as the variants are exclusive)
  • EuiI18nNumber (specific stories instead of playground as the variants are exclusive)
  • EuiIcon
  • EuiImage
  • EuiInlineEditText
  • EuiInlineEditTitle
  • EuiInnerText
  • EuiKeyPadMenu
  • EuiLink
  • EuiListGroup
  • EuiListGroupItem
  • EuiPinnableListGroup
  • EuiLoadingElastic
  • EuiLoadingChart
  • EuiLoadingSpinner
  • EuiLoadingLogo

And it updates the existing story for the following component:

  • EuiKeyPadMenuItem

QA

  • Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:

@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Mar 18, 2024
@mgadewoll mgadewoll marked this pull request as ready for review March 18, 2024 12:19
@mgadewoll mgadewoll requested a review from a team as a code owner March 18, 2024 12:19
@mgadewoll mgadewoll changed the title [Storybook] [Storybook] add stories for more components (letters I - L) Mar 18, 2024
@tkajtoch
Copy link
Member

I noticed a few very minor things, but other than that, the PR looks excellent, and all controls work as expected!

tkajtoch
tkajtoch approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll merged commit 14a1759 into elastic:main Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkajtoch tkajtoch tkajtoch approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New docs] Create stories for components starting with the letters I-L
4 participants
@mgadewoll @tkajtoch @kibanamachine @elasticmachine