Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Memoize EuiSkeleton components #7562

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Mar 7, 2024

Summary

Pulled out the original work/impetus from Kevin's PR (#7374) for PR atomic-ness and also because it dovetails nicely into our existing Emotion perf/memoization work (see #7561)

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked for accessibility including keyboard-only and screenreader modes
    • Checked in Chrome, Safari, Edge, and Firefox
      - [ ] Checked in mobile
  • Docs site QA - N/A
  • Code quality checklist - N/A
  • Release checklist - Skipping as this should not impact consumers or end users
  • Designer checklist - N/A

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@cee-chen cee-chen marked this pull request as ready for review March 8, 2024 18:05
@cee-chen cee-chen requested a review from a team as a code owner March 8, 2024 18:05
@cee-chen cee-chen merged commit aec0f67 into elastic:main Mar 11, 2024
14 of 15 checks passed
@cee-chen cee-chen deleted the emotion/memoize-skeleton-styles branch March 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants