Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Create hook utility for memoizing component styles per-theme #7529

Merged
merged 9 commits into from
Feb 15, 2024
Merged

[Emotion] Create hook utility for memoizing component styles per-theme #7529

merged 9 commits into from
Feb 15, 2024

Commits on Feb 14, 2024

  1. Set up memoized styles context

    @cee-chen
    cee-chen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c48d9d7 View commit details
    Browse the repository at this point in the history

  2. Test basic usage

    @cee-chen
    cee-chen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    001f7f1 View commit details
    Browse the repository at this point in the history

  3. Convert more complex EuiCode 

    - replace previous `UseEuiCodeSyntaxVariables` memoization with this new architecture
    @cee-chen
    cee-chen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3c4fdee View commit details
    Browse the repository at this point in the history

  4. Add a basic catch and warning for anonymous/non-static functions crea… 

    …ting map entries every rerender
    @cee-chen
    cee-chen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2c95aec View commit details
    Browse the repository at this point in the history

  5. changelog

    @cee-chen
    cee-chen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6051740 View commit details
    Browse the repository at this point in the history

  6. [REVERT ME] console.log to show number of code style calls

    @cee-chen
    cee-chen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    cd77f3a View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. [PR feedback] Switch from Map to WeakMap 

    - to allow browser GC / avoid possible edge cases with massive RAM usage
    @cee-chen
    cee-chen committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    875dd01 View commit details
    Browse the repository at this point in the history

  2. [misc naming] fix provider name to match context 

    - it's more verbose but oh well
    @cee-chen
    cee-chen committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    a039649 View commit details
    Browse the repository at this point in the history

  3. Revert "[REVERT ME] console.log to show number of code style calls" 

    This reverts commit cd77f3a.
    @cee-chen
    cee-chen committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    7864234 View commit details
    Browse the repository at this point in the history