Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiEmptyPrompt #7494

Merged
merged 14 commits into from
Feb 2, 2024
Merged

[Emotion] Convert EuiEmptyPrompt #7494

merged 14 commits into from
Feb 2, 2024

Commits on Jan 30, 2024

  1. Set up empty_prompt.styles.ts

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6b0a65e View commit details
    Browse the repository at this point in the history

  2. Convert more sub element CSS

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    742db43 View commit details
    Browse the repository at this point in the history

  3. Convert content wrapper + remove unnecessary extra div

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4dc48e1 View commit details
    Browse the repository at this point in the history

  4. Convert padding CSS to Emotion

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d7fb778 View commit details
    Browse the repository at this point in the history

  5. Footer: simplify border-radius CSS + use logical properties

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5999bf5 View commit details
    Browse the repository at this point in the history

  6. Create global mixin for border colors 

    - in same pattern as the background color mixin

+ DRY out border colors in `EuiCommentEvent`, which this mixin was based on

+ add snapshot tests

+ bonus memoization
    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    40aa2d6 View commit details
    Browse the repository at this point in the history

  7. [bonus perf] memoize useEuiBackgroundColorCSS as well

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    179ceda View commit details
    Browse the repository at this point in the history

  8. [misc] Clean up & performance improvements 

    - reorder vars, remove `let` jsx nodes in favor of useMemo
    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    bae9859 View commit details
    Browse the repository at this point in the history

  9. Snapshot updates

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ab7f117 View commit details
    Browse the repository at this point in the history

  10. Delete Sass

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    25377d4 View commit details
    Browse the repository at this point in the history

  11. changelog

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    85cd772 View commit details
    Browse the repository at this point in the history

  12. Unit test

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    668f1b0 View commit details
    Browse the repository at this point in the history

  13. Fix layout CSS regression with comment :|

    @cee-chen
    cee-chen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0e1d750 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. [PR feedback/discussion] Make selectors more goodly

    @cee-chen
    cee-chen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    68fb642 View commit details
    Browse the repository at this point in the history