[EuiDataGrid] Fix cell popovers not closing on outside grid click #7387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- thanks to the moved anchor behavior, we no longer need this, and it's actually messing up other UX
- I had the DOM markup/hierarchy wrong, so the cell popover was never closing + add bonus regresison test for ensuring that clicking other cell actions does not close the popover
- Escape key was causing a flash of animation if the mouse was not already hovered over the cell - this prevents it - DOM traversal is starting to feel pretty shaky, but not totally sure what to do about that
cee-chen
force-pushed
the
datagrid/cell-popover-close-fix
branch
from
c00f6e0 to
49a1d12
Compare
|
@tkajtoch do you mind giving this a quick QA/review sometime before EOW? 🙏 Just needed to knock this out, then I'm planning on taking a look at Kibana shenanigans later today! |
|
buildkite test this |
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
|
Non-code review; completed both QA steps successfully. |
tkajtoch
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed this bug while working on another (already in production) datagrid focus bug. Clicking anywhere outside the cell popover should auto close the popover; but right now in latest main it does not. This bug was introduced by #7343, so I want to get the fix in before the next release. I've added several E2E tests for it as well so it doesn't regress again.
QA
General checklist
- [ ] Checked in both light and dark modes- [ ] Checked in mobileand screenreader modesjest andcypress tests- [ ] A changelog entry exists and is marked appropriately.- I'm skipping the changelog on this since it's a bugfix for something that's still in main / hasn't yet been released- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)