-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSuperSelect] Allow rendering falsy but not nullish values #7362
Merged
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 344e430 - Browse repository at this point
Copy the full SHA 344e430View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fc2fb8 - Browse repository at this point
Copy the full SHA 6fc2fb8View commit details -
+ also fix selectedValue not using defaultValue, even though the input does
Configuration menu - View commit details
-
Copy full SHA for 6382025 - Browse repository at this point
Copy the full SHA 6382025View commit details -
[typing] Allow consumers to type EuiSuperSelect values to non-strings
e.g. booleans, numbers, etc.
Configuration menu - View commit details
-
Copy full SHA for a821313 - Browse repository at this point
Copy the full SHA a821313View commit details -
[opinionated] Prevent nullish values from being rendered in the dropd…
…own menu - to reduce UX confusion when options are shown in the dropdown but not the input nb: propTypes throws a dev error on this, but IMO it's better for the end-user to just not render the option at all
Configuration menu - View commit details
-
Copy full SHA for db5f400 - Browse repository at this point
Copy the full SHA db5f400View commit details -
[tech debt] Improve EuiSuperSelect tests
- convert from Enzyme to RTL - DRY out open dropdown logic - make the initial it renders test capture the portalled dropdown - no need to make a separate test for that - remove unnecessary portal mock - replace snapshots with specific assertions where it makes sense - remove unnecessary `onChange={() => {}}` and write an actual onChange test - remove other props if they're not actually being used by the test
Configuration menu - View commit details
-
Copy full SHA for 1fe90f7 - Browse repository at this point
Copy the full SHA 1fe90f7View commit details -
[perf] reduce rerender shenanigans
`= []` will cause a new instantiation every rerender, which makes the useMemo useless - just optional chaining instead
Configuration menu - View commit details
-
Copy full SHA for 0bd2636 - Browse repository at this point
Copy the full SHA 0bd2636View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61804f7 - Browse repository at this point
Copy the full SHA 61804f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e15fc04 - Browse repository at this point
Copy the full SHA e15fc04View commit details
Commits on Nov 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 55ae09e - Browse repository at this point
Copy the full SHA 55ae09eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.