Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiComboBox] Fix new input size util not resetting correctly #7240

Merged
merged 2 commits into from
Oct 2, 2023
Merged

[EuiComboBox] Fix new input size util not resetting correctly #7240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6305a1b
Fix new input size logic not resetting the rendered width on selection
cee-chen Oct 1, 2023
eb44556
changelog
cee-chen Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/components/combo_box/combo_box.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,26 @@ describe('EuiComboBox', () => {
);
});

it('correctly resets the input size when the search value is cleared', () => {
cy.realMount(<EuiComboBox options={[{ label: 'Test 1 2 3' }]} />);
cy.get('[data-test-subj="comboBoxSearchInput"]').realClick();

cy.realType('Test 1 2 3');
cy.get('[data-test-subj="comboBoxSearchInput"]').should(
'have.attr',
'style',
'inline-size: 67px;'
);

cy.realPress('{downarrow}');
cy.realPress('Enter');
cy.get('[data-test-subj="comboBoxSearchInput"]').should(
'have.attr',
'style',
'inline-size: 2px;'
);
});

it('does not exceed the maximum possible width of the input wrapper', () => {
cy.realMount(<EuiComboBox options={[]} />);
cy.get('[data-test-subj="comboBoxSearchInput"]').realClick();
Expand Down
23 changes: 8 additions & 15 deletions src/components/combo_box/combo_box_input/combo_box_input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import React, {
Component,
ChangeEventHandler,
FocusEventHandler,
KeyboardEventHandler,
RefCallback,
Expand Down Expand Up @@ -44,9 +43,9 @@ export interface EuiComboBoxInputProps<T> extends CommonProps {
isListOpen: boolean;
noIcon: boolean;
onBlur?: FocusEventHandler<HTMLInputElement>;
onChange?: (searchValue: string) => void;
onChange: (searchValue: string) => void;
onClear?: () => void;
onClick?: () => void;
onClick: () => void;
onCloseListClick: () => void;
onFocus: FocusEventHandler<HTMLInputElement>;
onOpenListClick: () => void;
Expand Down Expand Up @@ -147,22 +146,15 @@ export class EuiComboBoxInput<T> extends Component<
};

componentDidUpdate(prevProps: EuiComboBoxInputProps<T>) {
const { searchValue } = prevProps;
if (prevProps.searchValue !== this.props.searchValue) {
this.updateInputSize(this.props.searchValue);

// We need to update the position of everything if the user enters enough input to change
// the size of the input.
if (searchValue !== this.props.searchValue) {
// We need to update the position of everything if the user enters enough input to change
// the size of the input.
this.updatePosition();
}
}

inputOnChange: ChangeEventHandler<HTMLInputElement> = (event) => {
const { value } = event.target;

this.updateInputSize(value);
this.props.onChange?.(value);
};

render() {
const {
compressed,
Expand All @@ -173,6 +165,7 @@ export class EuiComboBoxInput<T> extends Component<
isDisabled,
isListOpen,
noIcon,
onChange,
onClear,
onClick,
onCloseListClick,
Expand Down Expand Up @@ -350,7 +343,7 @@ export class EuiComboBoxInput<T> extends Component<
disabled={isDisabled}
id={id}
onBlur={this.onBlur}
onChange={this.inputOnChange}
onChange={(event) => onChange(event.target.value)}
onFocus={this.onFocus}
onKeyDown={this.onKeyDown}
ref={this.inputRefCallback}
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/7240.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed `EuiComboBox` search input width not resetting correctly on selection
Loading