Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Introduce a renderCustomToolbar render prop #7150

Conversation

kertal
Copy link
Member

@kertal kertal commented Sep 1, 2023

Summary

This PR is introducing a renderCustomToolbar render prop allowing the customize EuiDataGrid

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs (using @default if default values are missing) and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_7150/

@elasticmachine
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

@kertal kertal marked this pull request as draft September 1, 2023 17:37
@timductive timductive marked this pull request as ready for review September 1, 2023 21:39
@timductive timductive merged commit 6588efc into elastic:add-display-selector-options Sep 1, 2023
@cee-chen
Copy link
Contributor

cee-chen commented Sep 2, 2023

@kertal @timductive What happened here? Why did this PR get merged in with failing CI checks, missing QA checklists, and zero review from the EUI team?

If y'all want to take over datagrid and responsibility for its maintenance - awesome. Let's talk about moving it out of the EUI codebase first.

@cee-chen
Copy link
Contributor

cee-chen commented Sep 2, 2023

Ah, wait, I see - this merged into a feature branch and not into main. Apologies.

This generally isn't the way we prefer to handle feature branches. If each individual PR into the feature branch is thoroughly and atomically reviewed/QA'd, the final (usually large) feature branch merge doesn't need more than a quick confidence/smoke check.

Can you let us know what the plan is for this work and how you'd like us to work with you on it? I was planning on reviewing Matthias's PR and am happy to work with y'all on that, but if you'd prefer something else, happy to chat about it.

@kertal
Copy link
Member Author

kertal commented Sep 4, 2023

@cee-chen Ooops, sorry for the confusion. The issue @timductive was working on was labeled as "help wanted". The issue became redundant with our conversation to use renderCustomToolbar @timductive. However parts of Tims code could be used also in the renderCustomToolbar work, so I asked him to create a PR for it, and I wanted to push a commit to it, applying your suggestion quickly (but I couldn't, that's why I created a PR to his branch), which he merged. This happened right before the weekend, so because the next task from my side would have been informing you, hey we've a Draft, how to precede?

And it seems both out way creating PRs were creating branches on EUI and not on our forks, which should be done differently ideally.

Happy to have a chat with you how we can bring this over the finishing line 👍

@kertal kertal deleted the data-grid-renderCustomToolbar branch September 4, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants