[EuiCollapsibleNavBeta] Add storybook QA test for ensuring flyouts sit above the nav #7051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
testing
cee-chen
commented
Aug 7, 2023
| @@ -34,6 +35,7 @@ const meta: Meta<EuiCollapsibleNavBetaProps> = { | |||
| args: { | |||
| side: 'left', | |||
| initialIsCollapsed: false, | |||
| width: 248, | |||
There was a problem hiding this comment.
This is an incidental change I forgot to include in #7034 - it's useful to preload the various Storybook control args with their default props so devs know what they are at a glance
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7051_buildkite/ |
cee-chen
force-pushed
the
collapsible-nav-beta
branch
from
28c35d6 to
c29bb50
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7051_buildkite/ |
💚 Build Succeeded
History
|
breehall
approved these changes
Aug 8, 2023
|
Thanks Bree! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per Marcialis's comment in elastic/kibana#161889 (comment), the new collapsible nav should sit below any flyout/modal/general overlay masks. This Storybook adds a quick way to visually QA that Kibana behavior and confirm it's working as expected.
QA
gh pr checkout 7051yarn storybookGeneral checklist
N/A, internal dev-only