Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiButtonIcon #6844

Merged
merged 11 commits into from
Jun 21, 2023
Merged

Commits on Jun 20, 2023

  1. [Setup] Clean up and DRY out shared button sizes

    - Remove `useEuiButtonRadiusCSS` in favor of a more agnostic `euiButtonSizeMap` - using the raw data is less strict and generates fewer classNames
    
    - `EuiButtonIcon` will shortly need the height/radius map and does not need to use all of `EuiButtonDisplay`'s logic (e.g. doesn't need fullWidth, or a content/text wrapper)
    
    - Move `_buttonSize` to internal fn to make it unexportable / clearer that its CSS is specific to `EuiButtonDisplay`
    cee-chen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    401eac8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f9db9a View commit details
    Browse the repository at this point in the history
  3. [EuiButtonIcon] Convert remaining base button style

    + focus CSS comes from a hook
    cee-chen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8558e85 View commit details
    Browse the repository at this point in the history
  4. [EuiButtonIcon] Convert disabled styles

    - this can mostly be simplified down from its Sass mixin to just the cursor CSS
    
    - the loading spinner color comment + logic is copied from `EuiButtonDisplay` - it previously existed in the `euiButtonContentDisabled` Sass mixin, but was targeting a selector that did not exist in EuiButtonIcon
    cee-chen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3448484 View commit details
    Browse the repository at this point in the history
  5. [EuiButtonIcon] Remove unused size modifiers/maps

    + convert enum types to new preferred syntax
    + move type enums to top of file
    cee-chen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9a3567e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    15e7f28 View commit details
    Browse the repository at this point in the history
  7. [EuiButtonIcon] Add Storybook playground

    + configure all playgrounds to sort props by required first, then alphabetical
    cee-chen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7008979 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fdd5c55 View commit details
    Browse the repository at this point in the history
  9. changelog

    cee-chen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8c1b3b0 View commit details
    Browse the repository at this point in the history
  10. Update downstream snapshots

    cee-chen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4806489 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Fix Storybook icon loading

    - preload all icons into the cache at once in the preview
    
    - this increases Storybook's startup time somewhat significantly, but will probably be necessary until we resolve dynamic icons for SSR/Vite
    cee-chen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    30a415c View commit details
    Browse the repository at this point in the history