-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiButtonIcon #6844
Commits on Jun 20, 2023
-
[Setup] Clean up and DRY out shared button sizes
- Remove `useEuiButtonRadiusCSS` in favor of a more agnostic `euiButtonSizeMap` - using the raw data is less strict and generates fewer classNames - `EuiButtonIcon` will shortly need the height/radius map and does not need to use all of `EuiButtonDisplay`'s logic (e.g. doesn't need fullWidth, or a content/text wrapper) - Move `_buttonSize` to internal fn to make it unexportable / clearer that its CSS is specific to `EuiButtonDisplay`
Configuration menu - View commit details
-
Copy full SHA for 401eac8 - Browse repository at this point
Copy the full SHA 401eac8View commit details -
[EuiButtonIcon] Implement sizes styles + move existing Emotion styles…
… to separate file
Configuration menu - View commit details
-
Copy full SHA for 2f9db9a - Browse repository at this point
Copy the full SHA 2f9db9aView commit details -
[EuiButtonIcon] Convert remaining base button style
+ focus CSS comes from a hook
Configuration menu - View commit details
-
Copy full SHA for 8558e85 - Browse repository at this point
Copy the full SHA 8558e85View commit details -
[EuiButtonIcon] Convert disabled styles
- this can mostly be simplified down from its Sass mixin to just the cursor CSS - the loading spinner color comment + logic is copied from `EuiButtonDisplay` - it previously existed in the `euiButtonContentDisabled` Sass mixin, but was targeting a selector that did not exist in EuiButtonIcon
Configuration menu - View commit details
-
Copy full SHA for 3448484 - Browse repository at this point
Copy the full SHA 3448484View commit details -
[EuiButtonIcon] Remove unused size modifiers/maps
+ convert enum types to new preferred syntax + move type enums to top of file
Configuration menu - View commit details
-
Copy full SHA for 9a3567e - Browse repository at this point
Copy the full SHA 9a3567eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15e7f28 - Browse repository at this point
Copy the full SHA 15e7f28View commit details -
[EuiButtonIcon] Add Storybook playground
+ configure all playgrounds to sort props by required first, then alphabetical
Configuration menu - View commit details
-
Copy full SHA for 7008979 - Browse repository at this point
Copy the full SHA 7008979View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdd5c55 - Browse repository at this point
Copy the full SHA fdd5c55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c1b3b0 - Browse repository at this point
Copy the full SHA 8c1b3b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4806489 - Browse repository at this point
Copy the full SHA 4806489View commit details
Commits on Jun 21, 2023
-
- preload all icons into the cache at once in the preview - this increases Storybook's startup time somewhat significantly, but will probably be necessary until we resolve dynamic icons for SSR/Vite
Configuration menu - View commit details
-
Copy full SHA for 30a415c - Browse repository at this point
Copy the full SHA 30a415cView commit details