Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiTable] Remove overflow/height animation causing Safari cross-browser issues #6826

Merged
merged 5 commits into from
Jun 2, 2023
Merged

[EuiTable] Remove overflow/height animation causing Safari cross-browser issues #6826

merged 5 commits into from
Jun 2, 2023

Commits on Jun 2, 2023

  1. [REVERT ME] Bug repro

    @cee-chen
    cee-chen committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    c2cf575 View commit details
    Browse the repository at this point in the history

  2. Remove problematic animation/overflow 

    The overflow/height combo causes Safari to return an empty `innerText` on initial render, which is problematic for expandable content that uses our inner text or copy utils.

Since the animation honestly is adding nothing functional, and is slightly laggy, I opted for an immediate height expansion and a very slight opacity/translate Y animation for a little extra pizazz.
    @cee-chen
    cee-chen committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    29b897b View commit details
    Browse the repository at this point in the history

  3. changelog

    @cee-chen
    cee-chen committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    e8d15c1 View commit details
    Browse the repository at this point in the history

  4. [PR feedback] Animation easing

    @cee-chen
    cee-chen authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    d9ffc21 View commit details
    Browse the repository at this point in the history

  5. Revert "[REVERT ME] Bug repro" 

    This reverts commit c2cf575.
    @cee-chen
    cee-chen committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    be01ea5 View commit details
    Browse the repository at this point in the history