[EuiDataGrid] Reduce hidden SR text when copying text from multiple cells #6817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6817/ |
1Copenut
approved these changes
May 26, 2023
There was a problem hiding this comment.
👍 This drives really well. I tested it with VO (Safari and FF) and NVDA (Chrome and FF). I had the screen reader running and used the mouse or track pad to highlight between 1 and 5 rows and paste them into Notes or Notepad respectively.
Notes does some odd things with Chrome/Edge in formatting, but none of the other browsers do this. 🤞 the Chromium fix that you're waiting on cleans this up too. Small nit but worth noting.
|
Thanks for the zippy review Trevor!
It was already doing this in prod for formatting, so yeah just a Chromium thing I think. The only thing that matters for this PR is that the SR text isn't in there 🤞 |
cee-chen
added a commit
to cee-chen/eui
that referenced
this pull request
May 30, 2023
…ltiple cells (elastic#6817)" This reverts commit 48c957b.
This was referenced May 30, 2023
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
May 31, 2023
This is a backport EUI upgrade to Kibana v8.8.1 containing an EuiDataGrid bugfix requested by the Discover team: elastic/eui#6804 (comment) ## [`77.1.4`](https://github.com/elastic/eui/tree/v77.1.4) - Updated `EuiDataGrid` to only render screen reader text announcing cell position if the cell is currently focused. This should improve the ability to copy and paste multiple cells without SR text. ([#6817](elastic/eui#6817))
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Jun 5, 2023
## Summary `[email protected]` ⏩ `[email protected]` - Most changes to source code in this PR are CSS cleanups/deprecations in `EuiSuperDatePicker`/`EuiDatePickerRange` - One team (ML) had a `inline` specific usage of `EuiDatePickerRange` that they reached out to us about via Slack, and that we have fixed in this PR. - All other usages of date picker components should have remained working as-is with no changes, but please ping us if you see otherwise! ___ ## [`81.2.0`](https://github.com/elastic/eui/tree/v81.2.0) - Updated `EuiSuperDatePicker` to accept an object configuration for `isDisabled` ([#6821](elastic/eui#6821)) **Bug fixes** - Fixed broken `EuiSuperDatePicker` styles ([#6821](elastic/eui#6821)) ## [`81.1.0`](https://github.com/elastic/eui/tree/v81.1.0) - Added `EuiInlineEditText` and `EuiInlineEditTitle` components ([#6757](elastic/eui#6757)) - Updated `EuiDatePickerRange` to support `inline` display ([#6795](elastic/eui#6795)) - Added an `onError` callback prop to `EuiErrorBoundary` ([#6810](elastic/eui#6810)) - Updated `EuiDataGrid` to only render screen reader text announcing cell position if the cell is currently focused. This should improve the ability to copy and paste multiple cells without SR text. ([#6817](elastic/eui#6817)) **Bug fixes** - Fixed `EuiDatePicker`'s `inline` display to correctly render and prevent user interaction when `disabled` or `readOnly` ([#6795](elastic/eui#6795)) - Fixed `EuiDatePicker`'s `inline` display to correctly render `isInvalid` and `isLoading` icons ([#6795](elastic/eui#6795)) **CSS-in-JS conversions** - Converted `EuiDatePickerRange` to Emotion ([#6795](elastic/eui#6795)) --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to provide an interim workaround to #6804 while #6806 is blocked due to a Chromium bug.
It adds the
hiddenattribute to SR text of cells that aren't currently being focused, which prevents the text from being selected/copied in all browsers. The currently focused cell should not behiddenand should still read out its cell position to screen readers.It's not 100% perfect as the cell position of the currently focused cell will still be end up in a copy/paste selection, but that's infinitely easier to edit once vs having to modify every single cell.
QA
General checklist