-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Storybook #6816
Merged
Merged
Set up Storybook #6816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ prettier linting/formatting autosave
cee-chen
commented
May 26, 2023
Preview documentation changes for this PR: https://eui.elastic.co/pr_6816/ |
1 similar comment
Preview documentation changes for this PR: https://eui.elastic.co/pr_6816/ |
ryankeairns
approved these changes
May 30, 2023
Thanks Ryan! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See: #6583
This PR installs and sets up Storybook via
npx storybook@latest --type react
, adds a very basic component test, and adds some extra global types in the Preview setup that lets us change our theme provider color mode and writing mode.This is still a very basic spike and still needs a decent amount of work done around extracting props to Storybook, but since it's not being published anywhere and just lives locally, there's no harm in merging it into production and continuing to tweak as we go (e.g. adding addons, investigating Chromatic, etc).
QA
yarn start
andyarn lint
and ensure everything still works as beforeyarn storybook
and confirm that a new local window opens up with anEuiErrorBoundary
exampleLight mode
andLTR
toggles in the component toolbar and confirm they change as expected per the below screencapReferences
Useful docs to familiarize yourself with: