Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Storybook #6816

Merged
merged 9 commits into from
May 30, 2023
Merged

Set up Storybook #6816

merged 9 commits into from
May 30, 2023

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented May 26, 2023

Summary

See: #6583

This PR installs and sets up Storybook via npx storybook@latest --type react, adds a very basic component test, and adds some extra global types in the Preview setup that lets us change our theme provider color mode and writing mode.

This is still a very basic spike and still needs a decent amount of work done around extracting props to Storybook, but since it's not being published anywhere and just lives locally, there's no harm in merging it into production and continuing to tweak as we go (e.g. adding addons, investigating Chromatic, etc).

QA

  • Regression testing - run yarn start and yarn lint and ensure everything still works as before
  • Run yarn storybook and confirm that a new local window opens up with an EuiErrorBoundary example
  • Click the Light mode and LTR toggles in the component toolbar and confirm they change as expected per the below screencap

screencap

References

Useful docs to familiarize yourself with:

@cee-chen cee-chen requested a review from a team May 26, 2023 18:46
scripts/dtsgenerator.js Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6816/

1 similar comment
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6816/

@cee-chen cee-chen self-assigned this May 26, 2023
@cee-chen
Copy link
Contributor Author

Thanks Ryan! :shipit:

@cee-chen cee-chen merged commit 1cb498a into elastic:main May 30, 2023
@cee-chen cee-chen deleted the storybook branch May 30, 2023 17:59
@JasonStoltz JasonStoltz mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants