Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade tabbable from 5.2.1 to 5.3.3 #6801

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

JasonStoltz
Copy link
Member

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to upgrade tabbable from 5.2.1 to 5.3.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 6 versions ahead of your current version.
  • The recommended version was released a year ago, on 2022-05-25.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@cee-chen
Copy link
Member

cee-chen commented May 23, 2023

Checked https://github.com/focus-trap/tabbable/releases and the minor release looks fine. We should probably consider upgrading to v6.x soon (breaking changes are dropping IE support and a displayCheck change which, fingers crossed, doesn't affect us)

EDIT: Since this PR has a failing snapshot in any case, we should just go ahead ahead and bogart this PR to upgrade tabbable to the latest major.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6801/

@cee-chen cee-chen disabled auto-merge June 1, 2023 21:12
@cee-chen cee-chen force-pushed the snyk-upgrade-370c2eff026a3b79bf9028bb28f53684 branch from bcaccdb to 70350b7 Compare August 11, 2023 15:41
- tabbable now requires specific `displayCheck` settings for JSDOM tests
Comment on lines +34 to +35
// @see https://github.com/focus-trap/tabbable#testing-in-jsdom
const mockTabbable = jest.requireActual('tabbable');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cee-chen
Copy link
Member

A quick update. Upgrading to v6.x and beyond wasn't doable - our Jest tests simply kept failing with errors like Should not already be working and Error: Uncaught [SyntaxError: 'slot):not([inert]' is not a valid selector]. Tabbable claims to already have fixed this in v6.1.2+ (focus-trap/tabbable#982), so I'm unsure why this is still an issue for us. It's possible that upgrading Jest and JSDOM versions (#6813) will fix this issue.

@cee-chen
Copy link
Member

cee-chen commented Aug 11, 2023

QA

  • EuiAccordion
  • EuiDataGrid
  • EuiContextMenu
  • EuiSkipLink
  • EuiInputPopover
  • EuiPopover

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6801_buildkite/

1 similar comment
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6801_buildkite/

@cee-chen cee-chen enabled auto-merge (squash) August 11, 2023 16:08
@cee-chen cee-chen merged commit e1f4005 into main Aug 11, 2023
1 check passed
@cee-chen cee-chen deleted the snyk-upgrade-370c2eff026a3b79bf9028bb28f53684 branch August 11, 2023 16:21
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@cee-chen cee-chen self-assigned this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants