-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Upgrade tabbable from 5.2.1 to 5.3.3 #6801
Conversation
Checked https://github.com/focus-trap/tabbable/releases and the minor release looks fine. We should probably consider upgrading to v6.x soon (breaking changes are dropping IE support and a EDIT: Since this PR has a failing snapshot in any case, we should just go ahead ahead and bogart this PR to upgrade |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6801/ |
Snyk has created this PR to upgrade tabbable from 5.2.1 to 5.3.3. See this package in npm: See this project in Snyk: https://app.snyk.io/org/eui/project/782ac3a8-8bb4-4658-baa9-190d6cb035f1?utm_source=github-enterprise&utm_medium=referral&page=upgrade-pr
bcaccdb
to
70350b7
Compare
- tabbable now requires specific `displayCheck` settings for JSDOM tests
// @see https://github.com/focus-trap/tabbable#testing-in-jsdom | ||
const mockTabbable = jest.requireActual('tabbable'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see focus-trap/tabbable#664
A quick update. Upgrading to |
QA
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6801_buildkite/ |
1 similar comment
Preview documentation changes for this PR: https://eui.elastic.co/pr_6801_buildkite/ |
💚 Build Succeeded
History
|
This PR was automatically created by Snyk using the credentials of a real user.
Snyk has created this PR to upgrade tabbable from 5.2.1 to 5.3.3.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs