Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Rename alert to warning and remove crossInACircleFilled #6608

Merged
merged 6 commits into from
Feb 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-docs/src/views/call_out/call_out_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const warningSnippet = [
import Danger from './danger';
const dangerSource = require('!!raw-loader!./danger');
const dangerSnippet = [
`<EuiCallOut title="Sorry, there was an error" color="danger" iconType="alert">
`<EuiCallOut title="Sorry, there was an error" color="danger" iconType="error">
<p><!-- Content --></p>
</EuiCallOut>
`,
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/call_out/warning.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React from 'react';
import { EuiCallOut, EuiLink, EuiButton } from '../../../../src';

export default () => (
<EuiCallOut title="Proceed with caution!" color="warning" iconType="alert">
<EuiCallOut title="Proceed with caution!" color="warning" iconType="warning">
<p>
Here be dragons. Don&rsquo;t wanna mess with no dragons. And{' '}
<EuiLink href="#">here&rsquo;s a link</EuiLink>.
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/control_bar/control_bar.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default () => {
{
controlType: 'icon',
id: 'status_icon',
iconType: 'alert',
iconType: 'warning',
color: 'warning',
'aria-label': 'Repo Status',
},
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/control_bar/control_bar_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const controlBarSnippet = `<EuiControlBar
{
controlType: 'icon',
id: 'status_icon',
iconType: 'alert',
iconType: 'warning',
color: 'warning',
'aria-label': 'Repo Status',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const DataGridCellPopoverExample = {
custom popover content but default cell actions.
<EuiCallOut
color="warning"
iconType="alert"
iconType="warning"
title="Using custom cell actions"
>
If deliberately leaving out the default{' '}
Expand Down Expand Up @@ -150,7 +150,7 @@ export const DataGridCellPopoverExample = {
</p>
<EuiCallOut
color="warning"
iconType="alert"
iconType="warning"
title="Cells with actions are always expandable"
>
If <EuiCode>columns.cellActions</EuiCode> is defined,{' '}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export const ElasticChartsAccessibilityExample = {
</>
}
color="warning"
iconType="alert"
iconType="warning"
/>
<EuiSpacer />
<p>
Expand Down
4 changes: 2 additions & 2 deletions src-docs/src/views/elastic_charts/pie_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const introCards = [
},
{
title: "Don't use",
iconType: 'crossInACircleFilled',
iconType: 'error',
iconColor: 'danger',
description: (
<>
Expand All @@ -62,7 +62,7 @@ const introCards = [
},
{
title: 'Be careful',
iconType: 'alert',
iconType: 'warning',
iconColor: 'warning',
description: (
<>
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/empty_prompt/_types_of_use_cases.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export const typesOfUseCases: {
),
},
example: {
iconType: 'alert',
iconType: 'error',
title: <h2>Unable to load your dashboards</h2>,
body: (
<p>
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/empty_prompt/empty_prompt_error.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { EuiEmptyPrompt } from '../../../../src/components';

export default () => (
<EuiEmptyPrompt
iconType="alert"
iconType="error"
color="danger"
title={<h2>Unable to load your dashboards</h2>}
body={
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/empty_prompt/empty_prompt_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ import Error from './empty_prompt_error';
const errorSource = require('!!raw-loader!./empty_prompt_error');
const errorSnippet = `<EuiEmptyPrompt
color="danger"
iconType="alert"
iconType="error"
title={<h2>There was an error</h2>}
/>`;

Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/empty_prompt/empty_prompt_states.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default () => {
case 'error':
emptyPromptProps = {
color: 'danger',
iconType: 'alert',
iconType: 'error',
title: <h2>Unable to load your dashboards</h2>,
body: (
<p>
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/guidelines/accessibility.js
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ export default {
<EuiCode>tabIndex=-1</EuiCode>.
</p>
<EuiCallOut
iconType="alert"
iconType="error"
title={
<span>
Using <EuiCode>tabIndex</EuiCode> values greater than 0 is
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/guidelines/writing_examples.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export const WritingExamples = () => {
>
<EuiCallOut
title="Index privileges missing"
iconType="alert"
iconType="error"
color="danger"
>
<p>
Expand Down
5 changes: 2 additions & 3 deletions src-docs/src/views/icon/icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
export const iconTypes = [
'accessibility',
'aggregate',
'alert',
'analyzeEvent',
'annotation',
'apmTrace',
Expand Down Expand Up @@ -62,7 +61,6 @@ export const iconTypes = [
'copyClipboard',
'cross',
'crosshairs',
'crossInACircleFilled',
'currency',
'cut',
'database',
Expand Down Expand Up @@ -277,6 +275,7 @@ export const iconTypes = [
'visTimelion',
'visVega',
'visVisualBuilder',
'warning',
'wordWrap',
'wordWrapDisabled',
'wrench',
Expand All @@ -285,7 +284,7 @@ export const iconTypes = [
export default () => (
<>
<EuiCodeBlock language="html" isCopyable paddingSize="m">
{'<EuiIcon type="alert" />'}
{'<EuiIcon type="warning" />'}
</EuiCodeBlock>
<EuiSpacer />
<EuiFlexGrid direction="column" columns={3}>
Expand Down
18 changes: 3 additions & 15 deletions src-docs/src/views/page_components/page_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,7 @@ export const PageExample = {

<EuiTableRow>
<EuiTableRowCell>
<EuiIcon
type="crossInACircleFilled"
color="danger"
title="no"
/>
<EuiIcon type="error" color="danger" title="no" />
</EuiTableRowCell>
<EuiTableRowCell>
<EuiIcon
Expand All @@ -204,18 +200,10 @@ export const PageExample = {

<EuiTableRow>
<EuiTableRowCell>
<EuiIcon
type="crossInACircleFilled"
color="danger"
title="no"
/>
<EuiIcon type="error" color="danger" title="no" />
</EuiTableRowCell>
<EuiTableRowCell>
<EuiIcon
type="crossInACircleFilled"
color="danger"
title="no"
/>
<EuiIcon type="error" color="danger" title="no" />
</EuiTableRowCell>

<EuiTableRowCell mobileOptions={{ width: '100%' }}>
Expand Down
6 changes: 3 additions & 3 deletions src-docs/src/views/page_template/examples.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export const PageTemplateInfo = {
intro: (
<>
<EuiCallOut
iconType="alert"
iconType="warning"
color="warning"
title={
<>
Expand Down Expand Up @@ -289,7 +289,7 @@ export const PageTemplateExample = () => (
</EuiText>
<EuiSpacer />
<EuiCallOut
iconType="alert"
iconType="warning"
color="warning"
title="Sidebars must be direct children declared in the same component."
>
Expand Down Expand Up @@ -353,7 +353,7 @@ export const PageTemplateExample = () => (
<EuiSpacer />

<EuiCallOut
iconType="alert"
iconType="warning"
color="warning"
title={
<>
Expand Down
4 changes: 2 additions & 2 deletions src-docs/src/views/resize_observer/resize_observer_hook.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ export const ResizeObserverHookExample = () => {
</p>
) : (
<p>
<EuiIcon type="crossInACircleFilled" color="danger" /> Browser does
not support ResizeObserver API. Using MutationObserver.
<EuiIcon type="error" color="danger" /> Browser does not support
ResizeObserver API. Using MutationObserver.
</p>
)}
<p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ const searchData: EuiSelectableTemplateSitewideOption[] = [
label: 'Totally custom',
searchableLabel: 'Totally custom with pink metadata',
icon: {
type: 'alert',
type: 'warning',
color: 'accent',
},
meta: [
Expand Down
4 changes: 2 additions & 2 deletions src-docs/src/views/stat/stat_combos.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default () => {
description={
<EuiTextColor color="accent">
<span>
<EuiIcon type="alert" color="danger" /> 12,20%
<EuiIcon type="error" color="danger" /> 12,20%
</span>
</EuiTextColor>
}
Expand Down Expand Up @@ -113,7 +113,7 @@ export default () => {
>
<EuiTextColor color="accent">
<span>
<EuiIcon type="alert" color="danger" /> 66,55%
<EuiIcon type="error" color="danger" /> 66,55%
</span>
</EuiTextColor>
</EuiStat>
Expand Down
6 changes: 3 additions & 3 deletions src-docs/src/views/toast/guidelines.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default () => {
title="The maximum bucket size of 200 was exceeded"
color="danger"
size="s"
iconType="alert"
iconType="error"
/>
<EuiSpacer size="s" />
<EuiCodeBlock>
Expand Down Expand Up @@ -307,7 +307,7 @@ and space to read it properly. Alternatively just link to a full page.
<GuideRuleExample
type="do"
text="The check icon reinforces that the action succeeded.
The alert icon helps users understand the message is an error."
The error icon helps users understand the message is an error."
>
<div>
<EuiToast
Expand All @@ -322,7 +322,7 @@ and space to read it properly. Alternatively just link to a full page.
<EuiToast
style={{ maxWidth: 300 }}
title="A dashboard named 'MyDashboard' already exists"
iconType="alert"
iconType="error"
color="danger"
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/toast/toast_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const dangerToastSnippet = [
`<EuiToast
title="Danger toast"
color="danger"
iconType="alert"
iconType="error"
onClose={closeToast}>
<!-- Raw HTML content -->
</EuiToast>`,
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/toast/warning.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ export default () => (
<EuiToast
title="Sometimes a title is enough!"
color="warning"
iconType="alert"
iconType="warning"
/>
);
2 changes: 1 addition & 1 deletion src-docs/src/views/tool_tip/icon_tip.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default () => {
<EuiIconTip
aria-label="Warning"
size="xl"
type="alert"
type="warning"
color="warning"
content="I do not think it means what you think it means"
/>
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/tool_tip/tool_tip.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export default () => (
<p>
This tooltip appears on the bottom of this icon:{' '}
<EuiToolTip position="bottom" content="Here is some tooltip text">
<EuiIcon tabIndex="0" type="alert" title="Icon with tooltip" />
<EuiIcon tabIndex="0" type="warning" title="Icon with tooltip" />
</EuiToolTip>
</p>
</EuiText>
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/window_event/window_event_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const WindowEventExample = {
<EuiCallOut
title="Be careful with global listeners"
color="warning"
iconType="alert"
iconType="warning"
>
<p>
Since window event listeners are global, they can conflict with
Expand Down
Loading