Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCodeBlock] Anchor annotation down left #6600

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

glitteringkatie
Copy link
Contributor

@glitteringkatie glitteringkatie commented Feb 14, 2023

Summary

Follow up to #6580 (comment)

image

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

- [ ] Checked in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs (using @default if default values are missing) and playground toggles
- [ ] Added documentation
- [ ] Checked Code Sandbox works for any docs examples

  • Added or updated jest and cypress tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
    - [ ] Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6600/

@glitteringkatie glitteringkatie marked this pull request as ready for review February 14, 2023 22:46
@glitteringkatie glitteringkatie changed the title Anchor annotation down left [EuiCodeBlock] Anchor annotation down left Feb 14, 2023
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6600/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6600/

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for the awesome contributions Katie!

@glitteringkatie glitteringkatie merged commit 815dc15 into elastic:main Feb 15, 2023
@glitteringkatie glitteringkatie deleted the down-left-annotation branch February 15, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants