Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSearchBar] Fix multiSelect: false filter behavior #6577

Merged
merged 3 commits into from
Feb 6, 2023
Merged

[EuiSearchBar] Fix multiSelect: false filter behavior #6577

merged 3 commits into from
Feb 6, 2023

Commits on Feb 3, 2023

  1. Fix broken behavior for multiSelect: false filters 

    - the diff being returned was catching on the first item (now unflagged) and sending that instead

- instead of using an unnecessary `.find`, use our new 3rd `changedOption` arg from `EuiSelectable` to immediately get the changed/selected option

- nb: this does require flipping all ternaries on `onOptionClick` b/c the new `changedOption` correctly sends the new updated state
    @cee-chen
    cee-chen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    b6cd765 View commit details
    Browse the repository at this point in the history

  2. Add regression tests for both multiselect false/or/true behavior

    @cee-chen
    cee-chen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    17bca04 View commit details
    Browse the repository at this point in the history

  3. changelog

    @cee-chen
    cee-chen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4bf0e18 View commit details
    Browse the repository at this point in the history