Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating EuiPopover screen reader text to include mobile cues. #6567

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Updating EuiPopover screen reader text to include mobile cues. #6567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ee9e51
Updating EuiPopover screen reader text to include mobile cues.
1Copenut Jan 31, 2023
fd17699
Added a changelog entry.
1Copenut Jan 31, 2023
4c95f76
Edited SR text to explain close actions more clearly.
1Copenut Feb 1, 2023
f9fc044
Snapshots updated to use latest screen reader text.
1Copenut Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion i18ntokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5121,7 +5121,7 @@
},
{
"token": "euiPopover.screenReaderAnnouncement",
"defString": "You are in a dialog. To close this dialog, hit escape.",
"defString": "You are in a dialog. Press Escape, or tap/click outside the dialog to close.",
"highlighting": "string",
"loc": {
"start": {
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/__snapshots__/column_selector.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`useDataGridColumnSelector columnSelector renders a toolbar button/popov
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div>
<div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/__snapshots__/column_sorting.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`useDataGridColumnSorting columnSorting renders a toolbar button/popover
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div>
<div
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/__snapshots__/keyboard_shortcuts.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ exports[`useDataGridKeyboardShortcuts returns a popover containing a list of key
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div>
<div
Expand Down
2 changes: 1 addition & 1 deletion src/components/popover/__snapshots__/popover.rtl.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ exports[`EuiPopover snapshot testing renders with popover contents 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div>
Hello world
Expand Down
22 changes: 11 additions & 11 deletions src/components/popover/__snapshots__/popover.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ exports[`EuiPopover props arrowChildren is rendered 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -175,7 +175,7 @@ exports[`EuiPopover props buffer 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -229,7 +229,7 @@ exports[`EuiPopover props buffer for all sides 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -296,7 +296,7 @@ exports[`EuiPopover props focusTrapProps is rendered 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -363,7 +363,7 @@ exports[`EuiPopover props isOpen renders true 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -417,7 +417,7 @@ exports[`EuiPopover props offset with arrow 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -466,7 +466,7 @@ exports[`EuiPopover props offset without arrow 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -520,7 +520,7 @@ exports[`EuiPopover props ownFocus defaults to true 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -619,7 +619,7 @@ exports[`EuiPopover props panelClassName is rendered 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -673,7 +673,7 @@ exports[`EuiPopover props panelPaddingSize is rendered 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down Expand Up @@ -728,7 +728,7 @@ exports[`EuiPopover props panelProps is rendered 1`] = `
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. To close this dialog, hit escape.
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/popover/popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ export class EuiPopover extends Component<Props, State> {
{ownFocus && (
<EuiI18n
token="euiPopover.screenReaderAnnouncement"
default="You are in a dialog. To close this dialog, hit escape."
default="You are in a dialog. Press Escape, or tap/click outside the dialog to close."
/>
)}
{popoverScreenReaderText}
Expand Down
1 change: 1 addition & 0 deletions upcoming_changelogs/6567.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Updated `EuiPopover` screen reader instructions for mobile and click behaviors