Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clearly mark EuiPageSideBarProps as deprecated #6468

Merged
merged 2 commits into from
Dec 7, 2022
Merged

More clearly mark EuiPageSideBarProps as deprecated #6468

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c48afd7
More clearly mark `EuiPageSideBarProps` as deprecated
cee-chen Dec 7, 2022
e28ae6a
changelog
cee-chen Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/page/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export {
export type { EuiPageSectionProps } from './page_section';
export { EuiPageSection } from './page_section';

export type { EuiPageSideBarProps } from './page_side_bar';
export type { EuiPageSideBarProps_Deprecated } from './page_side_bar';
export { EuiPageSideBar_Deprecated } from './page_side_bar';

export type { EuiPageSidebarProps } from './page_sidebar';
Expand Down
2 changes: 1 addition & 1 deletion src/components/page/page_side_bar/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
* Side Public License, v 1.
*/

export type { EuiPageSideBarProps } from './page_side_bar';
export type { EuiPageSideBarProps_Deprecated } from './page_side_bar';
export { EuiPageSideBar_Deprecated } from './page_side_bar';
7 changes: 5 additions & 2 deletions src/components/page/page_side_bar/page_side_bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ const paddingSizeToClassNameMap = {

export const PADDING_SIZES = keysOf(paddingSizeToClassNameMap);

export interface EuiPageSideBarProps
/**
* @deprecated Use the new EuiPageSidebarProps in page/page_sidebar instead
*/
export interface EuiPageSideBarProps_Deprecated
extends CommonProps,
HTMLAttributes<HTMLDivElement> {
/**
Expand All @@ -35,7 +38,7 @@ export interface EuiPageSideBarProps
/**
* @deprecated Use the new EuiPageSidebar in page/page_sidebar instead
*/
export const EuiPageSideBar_Deprecated: FunctionComponent<EuiPageSideBarProps> = ({
export const EuiPageSideBar_Deprecated: FunctionComponent<EuiPageSideBarProps_Deprecated> = ({
children,
className,
sticky,
Expand Down
2 changes: 1 addition & 1 deletion src/components/page/page_template.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { css } from '@emotion/react';
import { EuiPage, EuiPageProps } from './page';
import {
EuiPageSideBar_Deprecated as EuiPageSideBar,
EuiPageSideBarProps,
EuiPageSideBarProps_Deprecated as EuiPageSideBarProps,
} from './page_side_bar';
import { EuiPageBody, EuiPageBodyProps } from './page_body';
import { EuiPageHeader, EuiPageHeaderProps } from './page_header';
Expand Down