Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiText] Set default color to inherit #6267

Merged
merged 7 commits into from
Sep 30, 2022
Merged

[EuiText] Set default color to inherit #6267

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bfee66b
[EuiText] Set default color to `inherit`
elizabetdev Sep 27, 2022
ac3f0ee
Adding CL
elizabetdev Sep 28, 2022
7105e4f
Fix typo
elizabetdev Sep 28, 2022
f278593
Exclude `inherit` from CSSProperties['color']
elizabetdev Sep 28, 2022
df9f0f1
Revert `color` type
elizabetdev Sep 28, 2022
2825643
Reverting line changes
elizabetdev Sep 28, 2022
a229acf
Merge remote-tracking branch 'upstream/main' into change-text-default…
elizabetdev Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/accordion/__snapshots__/accordion.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,7 +1051,7 @@ exports[`EuiAccordion props isLoadingMessage is rendered 1`] = `
role="progressbar"
/>
<div
class="euiText emotion-euiText-s"
class="euiText emotion-euiText-s-euiTextColor-inherit"
>
<p>
Please wait
Expand Down
64 changes: 32 additions & 32 deletions src/components/card/__snapshots__/card.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`EuiCard betaBadgeProps renders href 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -56,7 +56,7 @@ exports[`EuiCard horizontal selectable 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -103,7 +103,7 @@ exports[`EuiCard is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -132,7 +132,7 @@ exports[`EuiCard props a null icon 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -162,7 +162,7 @@ exports[`EuiCard props accepts div props like style 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -217,7 +217,7 @@ exports[`EuiCard props children with description 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -251,7 +251,7 @@ exports[`EuiCard props display accent is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -280,7 +280,7 @@ exports[`EuiCard props display danger is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -309,7 +309,7 @@ exports[`EuiCard props display plain is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -338,7 +338,7 @@ exports[`EuiCard props display primary is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -367,7 +367,7 @@ exports[`EuiCard props display subdued is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -396,7 +396,7 @@ exports[`EuiCard props display success is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -425,7 +425,7 @@ exports[`EuiCard props display transparent is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -454,7 +454,7 @@ exports[`EuiCard props display warning is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -483,7 +483,7 @@ exports[`EuiCard props footer 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -519,7 +519,7 @@ exports[`EuiCard props hasBorder 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -548,7 +548,7 @@ exports[`EuiCard props horizontal 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -580,7 +580,7 @@ exports[`EuiCard props href supports href as a link 1`] = `
</a>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -617,7 +617,7 @@ exports[`EuiCard props icon 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -660,7 +660,7 @@ exports[`EuiCard props image 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -691,7 +691,7 @@ exports[`EuiCard props isDisabled 1`] = `
</button>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -720,7 +720,7 @@ exports[`EuiCard props paddingSize l is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -749,7 +749,7 @@ exports[`EuiCard props paddingSize m is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -778,7 +778,7 @@ exports[`EuiCard props paddingSize none is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -807,7 +807,7 @@ exports[`EuiCard props paddingSize s is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -836,7 +836,7 @@ exports[`EuiCard props paddingSize xl is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -865,7 +865,7 @@ exports[`EuiCard props paddingSize xs is rendered 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -894,7 +894,7 @@ exports[`EuiCard props selectable 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -939,7 +939,7 @@ exports[`EuiCard props textAlign 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -968,7 +968,7 @@ exports[`EuiCard props titleElement 1`] = `
</span>
</h4>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -997,7 +997,7 @@ exports[`EuiCard props titleElement with nodes 1`] = `
</span>
</h4>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down Expand Up @@ -1026,7 +1026,7 @@ exports[`EuiCard props titleSize 1`] = `
</span>
</p>
<div
class="euiText emotion-euiText-s-euiCard__description"
class="euiText emotion-euiText-s-euiTextColor-inherit-euiCard__description"
id="generated-idDescription"
>
<p>
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/body/__snapshots__/data_grid_cell.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`EuiDataGridCell componentDidUpdate handles the cell popover by forwarding the cell's DOM node and contents to the parent popover context 1`] = `
Array [
<div
class="euiText emotion-euiText-m"
class="euiText emotion-euiText-m-euiTextColor-inherit"
>
<div>
<button
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/__snapshots__/column_sorting.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ exports[`useDataGridColumnSorting columnSorting renders a toolbar button/popover
class="euiFlexItem"
>
<div
class="euiText emotion-euiText-xs"
class="euiText emotion-euiText-xs-euiTextColor-inherit"
>
<p>
Column A
Expand Down
2 changes: 1 addition & 1 deletion src/components/modal/__snapshots__/confirm_modal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Array [
class="euiModalBody__overflow"
>
<div
class="euiText emotion-euiText-m"
class="euiText emotion-euiText-m-euiTextColor-inherit"
data-test-subj="confirmModalBodyText"
>
<p>
Expand Down
2 changes: 1 addition & 1 deletion src/components/page/page_header/__snapshots__/page_header.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ exports[`EuiPageHeader props page content props are passed down is rendered 1`]
class="euiSpacer euiSpacer--l emotion-euiSpacer-l"
/>
<div
class="euiText emotion-euiText-constrainedWidth-m"
class="euiText emotion-euiText-constrainedWidth-m-euiTextColor-inherit"
>
<p>
Description
Expand Down
2 changes: 1 addition & 1 deletion src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ exports[`EuiPageHeaderContent props description is rendered 1`] = `
class="euiFlexItem"
>
<div
class="euiText emotion-euiText-constrainedWidth-m"
class="euiText emotion-euiText-constrainedWidth-m-euiTextColor-inherit"
>
<p>
Description
Expand Down
2 changes: 1 addition & 1 deletion src/components/pagination/__snapshots__/pagination.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ exports[`EuiPagination props compressed is rendered 1`] = `
/>
</button>
<div
class="euiText euiPagination__compressedText emotion-euiText-s-euiPagination__compressedText"
class="euiText euiPagination__compressedText emotion-euiText-s-euiTextColor-inherit-euiPagination__compressedText"
>
<span>
1
Expand Down
Loading