[CI] Skip a11y testing to stop CI from hanging #6266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6266/ |
cee-chen
changed the title
chandlerprall
approved these changes
Sep 27, 2022
1Copenut
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
LGTM. I agree Cypress + cypress-axe are a long-term winner. I've been reading this blog post https://timdeschryver.dev/blog/setting-up-cypress-with-axe-for-accessibility#automating-a-whole-website that outlines a fairly simple way to parse a sitemap and loop through pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're seeing multiple hanging CI issues on the a11y testing step:
It's not totally clear why, but this only started happening recently (Sept 21st/22nd). This PR skips said step in order to unblock multiple PRs from being merged. Long term, we should potentially consider moving our a11y tests to using Cypress/cypress-axe instead of building our docs and running axe against docs.
Note: I accidentally pushed this commit directly up to main and had to reverted it on main 💀 please disregard that oopsie
Checklist