Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiAccordion] Remove will-change CSS #6235

Merged
merged 5 commits into from
Sep 19, 2022
Merged

[EuiAccordion] Remove will-change CSS #6235

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
052e679
[REVERT ME] test datagrid full screen bug when nested within accordion
cee-chen Sep 13, 2022
c472a69
[EuiAccordion] Remove `will-change` CSS
cee-chen Sep 13, 2022
732c3d8
changelog
cee-chen Sep 13, 2022
fa5071e
[PR feedback] typo
constancecchen Sep 14, 2022
db0f7d2
Revert "[REVERT ME] test datagrid full screen bug when nested within …
cee-chen Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 23 additions & 20 deletions src-docs/src/views/datagrid/basics/datagrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { Link } from 'react-router-dom';
import { fake } from 'faker';

import {
EuiAccordion,
EuiButton,
EuiButtonEmpty,
EuiButtonIcon,
Expand Down Expand Up @@ -411,25 +412,27 @@ export default () => {
});

return (
<DataContext.Provider value={raw_data}>
<EuiDataGrid
aria-label="Data grid demo"
columns={columns}
columnVisibility={{ visibleColumns, setVisibleColumns }}
trailingControlColumns={trailingControlColumns}
rowCount={raw_data.length}
renderCellValue={RenderCellValue}
inMemory={{ level: 'sorting' }}
sorting={{ columns: sortingColumns, onSort }}
pagination={{
...pagination,
pageSizeOptions: [10, 50, 100],
onChangeItemsPerPage: onChangeItemsPerPage,
onChangePage: onChangePage,
}}
onColumnResize={onColumnResize.current}
ref={gridRef}
/>
</DataContext.Provider>
<EuiAccordion id="fdsfasdf" buttonContent="fullscreen testing">
<DataContext.Provider value={raw_data}>
<EuiDataGrid
aria-label="Data grid demo"
columns={columns}
columnVisibility={{ visibleColumns, setVisibleColumns }}
trailingControlColumns={trailingControlColumns}
rowCount={raw_data.length}
renderCellValue={RenderCellValue}
inMemory={{ level: 'sorting' }}
sorting={{ columns: sortingColumns, onSort }}
pagination={{
...pagination,
pageSizeOptions: [10, 50, 100],
onChangeItemsPerPage: onChangeItemsPerPage,
onChangePage: onChangePage,
}}
onColumnResize={onColumnResize.current}
ref={gridRef}
/>
</DataContext.Provider>
</EuiAccordion>
);
};
1 change: 0 additions & 1 deletion src/components/accordion/accordion.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ export const euiAccordionChildWrapperStyles = ({ euiTheme }: UseEuiTheme) => ({
${euiTheme.animation.resistance},
opacity ${euiTheme.animation.normal} ${euiTheme.animation.resistance};
visibility: hidden;
will-change: opacity, visibility, ${logicals.height};

&:focus {
outline: none; // Hide focus ring because of tabindex=-1 on Safari
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6235.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed `EuiDataGrid`'s broken fullscreen mode when ensted within an `EuiAccordion`
cee-chen marked this conversation as resolved.
Show resolved Hide resolved