Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CollapsedItemActions] Account for null ref object #6145

Merged
merged 3 commits into from
Aug 17, 2022
Merged

[CollapsedItemActions] Account for null ref object #6145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ef70d9
account for null ref object
thompsongl Aug 17, 2022
e0ff985
CL
thompsongl Aug 17, 2022
e7b82dc
revert docs change
thompsongl Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/basic_table/collapsed_item_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,11 @@ export class CollapsedItemActions<T> extends Component<
});
};

registerPopoverDiv = (popoverDiv: HTMLDivElement) => {
registerPopoverDiv = (popoverDiv: HTMLDivElement | null) => {
if (!this.popoverDiv) {
this.popoverDiv = popoverDiv;
this.popoverDiv.addEventListener('focusout', this.onPopoverBlur);
this.popoverDiv &&
this.popoverDiv.addEventListener('focusout', this.onPopoverBlur);
}
};

Expand Down
4 changes: 4 additions & 0 deletions upcoming_changelogs/6145.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Bug fixes**

- Fixed `CollapsedItemActions` ref callback not accounting for `null` value