Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiCallout] Set grow={false} #5963

Merged
merged 4 commits into from
Jun 13, 2022
Merged

[EuiCallout] Set grow={false} #5963

merged 4 commits into from
Jun 13, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jun 9, 2022 •
edited
Loading

Summary

#5870 updated EuiCallout to use EuiPanel instead of a div. The EuiPanel configuration left grow to use the default value of true which adds flex-grow: 1; and consumes vertical height when possible.

This PR sets grow={false} on the EuiCallout configuration.

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5963/

cee-chen
cee-chen approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛⚡

@thompsongl
Copy link
Contributor Author

@cchaos Does this look ok? Just want to be sure you didn't intentionally allow grow

cchaos
cchaos approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you for putting up the quick fix. I'm always surprised at implementations that use column flex layouts. 🦹‍♀️

upcoming_changelogs/5963.md Outdated Show resolved Hide resolved
@thompsongl thompsongl enabled auto-merge (squash) June 13, 2022 15:29
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5963/

@thompsongl thompsongl merged commit 8642c8a into elastic:main Jun 13, 2022
@thompsongl thompsongl mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thompsongl @kibanamachine @cee-chen @cchaos