Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSS-in-JS] Create font scale functions/mixins #5822
[CSS-in-JS] Create font scale functions/mixins #5822
Changes from 16 commits
37f3590
e2777d4
626bbdb
d96b3fd
079f884
4dadf55
0a37a11
46ea7e5
c336f0d
67a3d97
427269a
a5fdc49
68b4b01
7ad158e
860aeaf
f56a280
b962785
e959981
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love some help on seeing if we can have these body values updatable. The difference here, that I couldn't quite work out, is that the options from a specific list of of keys available in the theme. So we'd need a new form control type (EuiSelect) to handle that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something you want to address in this PR? I'm not sure I understand the problem well enough to help at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily, if it seems too complicated. Probably best to get the hooks in now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ❤️ this. Super smart way to do the theming "mixins" to also be used as "css utilities". Makes things very flexible.