Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] Miscellaneous updates #5574

Merged
merged 5 commits into from
Jan 28, 2022
Merged

[a11y] Miscellaneous updates #5574

merged 5 commits into from
Jan 28, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jan 28, 2022 •
edited
Loading

Summary

Miscellaneous updates in support of #3733 and other EuiSelectable conversions

  • EuiFormRow: Add referenceable id for the generated label
    • ${id}-label pattern
    • Useful for aria-labelledby
  • EuiPopover: Optional attribute configurations to aid screen reader announcements
  • EuiIputPopover: Allow consumers to attach refs
  • src/services: Convenience wildcard export

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl requested a review from 1Copenut January 28, 2022 16:58
@thompsongl thompsongl marked this pull request as ready for review January 28, 2022 16:58
@thompsongl thompsongl mentioned this pull request Jan 28, 2022
Merged
9 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5574/

1Copenut
1Copenut approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@thompsongl thompsongl merged commit 3d9df07 into elastic:main Jan 28, 2022
@breehall breehall mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Copenut 1Copenut 1Copenut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsongl @kibanamachine @1Copenut