Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox][KEYBOARD]: Removing tabindex -1 from EuiComboboxPill SVG #5560

Merged
merged 5 commits into from
Jan 27, 2022
Merged

[EuiComboBox][KEYBOARD]: Removing tabindex -1 from EuiComboboxPill SVG #5560

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1a0fcb
Removing a tabindex -1 from EuiComboboxPill SVG.
1Copenut Jan 25, 2022
6441b77
Adding changelog entry for PR 5560
1Copenut Jan 25, 2022
a1bc359
Merging upstream master for CI failure.
1Copenut Jan 27, 2022
6a92b0a
Updating snapshot for CI test suite.
1Copenut Jan 27, 2022
5f81f95
Adding a newline in changelog entry.
1Copenut Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [`main`](https://github.com/elastic/eui/tree/main)

No public interface changes since `46.1.0`.
**Bug fixes**
- Fixed an accessibility issue where `EuiComboBoxPill` close button had a nested interactive element ([#5560](https://github.com/elastic/eui/pull/5560))

## [`46.1.0`](https://github.com/elastic/eui/tree/v46.1.0)

Expand Down
1 change: 0 additions & 1 deletion src/components/combo_box/combo_box_input/combo_box_pill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ export class EuiComboBoxPill<T> extends Component<EuiComboBoxPillProps<T>> {
{(removeSelection: string) => (
<EuiBadge
className={classes}
closeButtonProps={{ tabIndex: -1 }}
color={color}
iconOnClick={this.onCloseButtonClick}
iconOnClickAriaLabel={removeSelection}
Expand Down
1 change: 0 additions & 1 deletion src/components/provider/__snapshots__/provider.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1496,7 +1496,6 @@ exports[`EuiProvider providing an @emotion cache config applies the cache to glo
"before": null,
"container": <head />,
"ctr": 0,
"insertionPoint": undefined,
1Copenut marked this conversation as resolved.
Show resolved Hide resolved
"isSpeedy": false,
"key": "testing",
"nonce": undefined,
Expand Down