Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the same --inList styles for checkboxes and radios without labels #542

Merged
merged 4 commits into from
Mar 20, 2018
Merged

Using the same --inList styles for checkboxes and radios without labels #542

merged 4 commits into from
Mar 20, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Mar 20, 2018

Fixes #541

screen capture on 2018-03-19 at 21-44-35

@arkwright: Basically using your solution here but just the opposite and appending a --noLabel selector to the --inList selector.

@cchaos cchaos requested a review from arkwright March 20, 2018 01:51
arkwright
arkwright approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@arkwright arkwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally for my use case and this works great! Code LGTM. Thank you!

@cchaos cchaos merged commit dfcd633 into elastic:master Mar 20, 2018
@cchaos cchaos deleted the 541-checkbox-no-label branch March 20, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkwright arkwright arkwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchaos @arkwright