Remove font smoothing from reset #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I think you're right about sticking to standards. Though, we had then also talked about reducing the weight from 400 to 300? |
|
Gonna merge this so we can get it in the next release. @cchaos we can figure out the 300-400 stuff separately. I don't know the answer there, but think either can work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes elastic/kibana#16662
This removes font-smoothing for webkit browsers as a base reset. @cchaos and I tend to prefer font-smoothing on, and it can be very subjective, but according to https://caniuse.com/#feat=font-smooth
We should stick to standards when we can. cc @elastic/eui-design