Deprecations, October 2021 Edition #5323

thompsongl · 2021-10-26T15:09:48Z

Summary

Completes the October 2021 round of deprecations (#1469)

Remove EuiCodeEditor ([Docs] EuiCodeEditor - Removed examples and added deprecation notice #4683)

Remove betaBadgeLabel, betaBadgeTooltipContent, betaBadgeTitle props from EuiCard ([EuiBetaBadge] Add color and size props and support for click event #4798)

Remove EuiLoadingKibana (New [EuiLoaderLogo] and other loader updates #4835)

Remove secondary color prop options (Updating buttons and links to promote success over secondary color and fixed EuiButtonIcon colors #4874, Updating components to use success over secondary color option #4888)

Remove subdued color prop option from EuiButtonIcon (Updating buttons and links to promote success over secondary color and fixed EuiButtonIcon colors #4874)

Remove panelPaddingSize from EuiPageContent ([Page Layouts] Adding content props to EuiPageHeader for pre-determined page layout patterns #4451)

Remove makeId (Replace makeId with htmlIdGenerator #3112)

Remove old mobile only props from EuiTableRowCell

Best (re)viewed by individual commit

Upgrade path: https://gist.github.com/thompsongl/506f6f86201c83d61cc850170fd49467

Checklist

~~- [ ] Check against all themes for compatibility in both light and dark modes~~
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox

Props have proper autodocs and playground toggles

- [ ] Added documentation

Checked Code Sandbox works for any docs examples
Added or updated jest and cypress tests
Checked for breaking changes and labeled appropriately

~~- [ ] Checked for accessibility including keyboard-only and screenreader modes~~

A changelog entry exists and is marked appropriately

…from EuiCard

kibanamachine · 2021-10-26T18:23:47Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

thompsongl · 2021-10-26T19:18:11Z

Opening for review but won't merge prior to the October 26ish release (v40.1.0).

kibanamachine · 2021-10-26T19:34:59Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

thompsongl · 2021-10-26T21:35:36Z

jenkins test this

kibanamachine · 2021-10-26T22:05:30Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

chandlerprall · 2021-10-27T13:56:26Z

package.json

@@ -71,7 +71,6 @@
    "mdast-util-to-hast": "^10.0.0",
    "numeral": "^2.0.6",
    "prop-types": "^15.6.0",
-    "react-ace": "^7.0.5",


Unable to describe the joy I feel

chandlerprall

Changes LGTM, lots of great deletions 🎉

Curious if you've tried a build with these in Kibana, or otherwise have an idea on the effort this update will require?

thompsongl · 2021-10-27T14:31:40Z

Curious if you've tried a build with these in Kibana, or otherwise have an idea on the effort this update will require?

Planning to post a comment about the upgrade path today. secondary -> success is going to be tedious, but I'll get some numbers behind it.

thompsongl · 2021-10-27T16:29:04Z

Upgrade path: https://gist.github.com/thompsongl/506f6f86201c83d61cc850170fd49467

thompsongl · 2021-10-27T17:15:20Z

Some stats from Kibana:

81 direct uses of color="secondary" but additional interpolated cases exist color={buttonColor}
- type_check will be helpful
- Sifting through js files for secondary strings is going to be rough 🥵
A few instances of color="subdued" on EuiButtonIcon
- type_check will be helpful
- Note that other components (e.g., EuiText, EuiPanel) don't need updating
Quite a few mobile option props
- hideForMobile, mainly, but these are easy to search for
- fullWidth will require some sifting though search results
9 instances of EuiLoadingKibana
6 instances of EuiCodeEditor imported from @elastic/eui
0 instances of makeId 🎉

cchaos

I'm going to test this incrementally per commit as suggested.

✅ EuiCard beta badge

I'm pushing up a few more updates mainly to the docs and prop comment.

src/components/card/card.tsx

- Convert touched docs files to `.tsx` - Simplified one of the examples - Updated prop comment

cchaos

✅ [EuiPageContent] panelPaddingSize

cchaos

✅ EuiButtonIcon subdued

kibanamachine · 2021-10-27T21:23:52Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

…into 1469-october-2021

thompsongl · 2021-10-28T15:24:51Z

This will have an even greater impact, so I'm ok if we want to do a second PR specifically for theme tokens.

Great, let's do a second PR for that

kibanamachine · 2021-10-28T15:54:14Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

kibanamachine · 2021-10-28T16:25:58Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

…into 1469-october-2021

kibanamachine · 2021-10-28T17:19:15Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

kibanamachine · 2021-10-28T18:00:48Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

And fixed `align: center` for mobile

- [EuiMark] change prop type of `children` from `string` to `ReactNode` - [useEuiTextDiff] renders back a `span` instead of `div` - Fix docs-only erros

kibanamachine · 2021-10-28T18:31:40Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

cchaos

😅 Whew! Can't wait for the Kibana upgrade ... lol.

I did a final run though of our docs pages checking for console errors. We should be good to go!

kibanamachine · 2021-10-28T18:57:46Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5323/

thompsongl · 2021-10-29T14:45:50Z

Thanks for the assist, @cchaos

Merging 🙈

thompsongl added 7 commits October 25, 2021 14:47

remove betaBadgeLabel, betaBadgeTooltipContent, betaBadgeTitle props …

1ed22be

…from EuiCard

remove panelPaddingSize from EuiPageContent

bebb30d

remove secondary color prop options

805cd26

remove makeId

4ab8a68

remove old mobile only props from EuiTableRowCell

036b25b

remove EuiLoadingKibana

e0a137d

remove EuiCodeEditor

ce99781

thompsongl mentioned this pull request Oct 26, 2021

Migrate instances of EuiCodeEditor to CodeEditor elastic/kibana#106931

Open

42 tasks

remove loading_kibana and code_editor scss imports

0a9af3b

thompsongl added the breaking change label Oct 26, 2021

remove subdued color prop option from EuiButtonIcon

29689c9

thompsongl added 2 commits October 26, 2021 13:54

Merge branch 'master' into 1469-october-2021

cf6397f

CL

d3b3f7e

thompsongl marked this pull request as ready for review October 26, 2021 19:18

thompsongl requested review from cchaos and chandlerprall October 26, 2021 19:18

chandlerprall reviewed Oct 27, 2021

View reviewed changes

chandlerprall approved these changes Oct 27, 2021

View reviewed changes

secondary -> success

84fea9e

cchaos reviewed Oct 27, 2021

View reviewed changes

src/components/card/card.tsx Show resolved Hide resolved

EuiCard beta badge:

b9c8acd

- Convert touched docs files to `.tsx` - Simplified one of the examples - Updated prop comment

cchaos reviewed Oct 27, 2021

View reviewed changes

thompsongl added 2 commits October 28, 2021 10:09

Merge branch '1469-october-2021' of https://github.com/thompsongl/eui …

b41f1f8

…into 1469-october-2021

clean up

321a903

[EuiButtonDisplay] Setting better fallbacks for color vs null

eae3495

thompsongl added 3 commits October 28, 2021 11:44

Merge branch 'master' into 1469-october-2021

9a8ac1e

Merge branch '1469-october-2021' of https://github.com/thompsongl/eui …

a25f002

…into 1469-october-2021

restore i18ntokens.json

c9f9525

Merge branch 'master' into 1469-october-2021

66ef400

cchaos added 4 commits October 28, 2021 14:03

Found more mobileOptions.fullWidth

ae1bca6

And fixed `align: center` for mobile

🤦‍♀️ Undo secondary button

0dde0a3

A couple last fixes found from console errors

2d70163

- [EuiMark] change prop type of `children` from `string` to `ReactNode` - [useEuiTextDiff] renders back a `span` instead of `div` - Fix docs-only erros

cl

6e285a8

cchaos approved these changes Oct 28, 2021

View reviewed changes

thompsongl merged commit 09791d7 into elastic:master Oct 29, 2021

cchaos mentioned this pull request Nov 2, 2021

[Breaking] Remove Sass vars $euiColorSecondary and $euiColorSecondaryText #5345

Merged

2 tasks

thompsongl mentioned this pull request Nov 2, 2021

Upgrade EUI to v41.0.0 elastic/kibana#117242

Merged

thompsongl mentioned this pull request Nov 15, 2021

[EuiCodeEditor & EuiCodeBlock] Recommendations and migration guidance #3807

Closed

3 tasks

Karql mentioned this pull request Mar 10, 2022

Migrate EuiCodeEditor to CodeEditor Karql/elastalert-kibana-plugin#27

Closed

romanwozniak mentioned this pull request Mar 15, 2022

Add create router version feature caraml-dev/turing#179

Merged

GerardoPM mentioned this pull request Apr 5, 2022

eui-card-41.4.0 prysmex/ember-eui#130

Merged

yenienserrano mentioned this pull request Nov 16, 2022

Compatibility with Elastic 8 wazuh/wazuh-dashboard-plugins#4567

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecations, October 2021 Edition #5323

Deprecations, October 2021 Edition #5323

thompsongl commented Oct 26, 2021 •

edited

Loading

kibanamachine commented Oct 26, 2021

thompsongl commented Oct 26, 2021

kibanamachine commented Oct 26, 2021

thompsongl commented Oct 26, 2021

kibanamachine commented Oct 26, 2021

chandlerprall Oct 27, 2021

chandlerprall left a comment

thompsongl commented Oct 27, 2021

thompsongl commented Oct 27, 2021

thompsongl commented Oct 27, 2021

cchaos left a comment •

edited

Loading

cchaos left a comment

cchaos left a comment

kibanamachine commented Oct 27, 2021

thompsongl commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

cchaos left a comment

kibanamachine commented Oct 28, 2021

thompsongl commented Oct 29, 2021

Deprecations, October 2021 Edition #5323

Deprecations, October 2021 Edition #5323

Conversation

thompsongl commented Oct 26, 2021 • edited Loading

Summary

Checklist

kibanamachine commented Oct 26, 2021

thompsongl commented Oct 26, 2021

kibanamachine commented Oct 26, 2021

thompsongl commented Oct 26, 2021

kibanamachine commented Oct 26, 2021

chandlerprall Oct 27, 2021

Choose a reason for hiding this comment

chandlerprall left a comment

Choose a reason for hiding this comment

thompsongl commented Oct 27, 2021

thompsongl commented Oct 27, 2021

thompsongl commented Oct 27, 2021

cchaos left a comment • edited Loading

Choose a reason for hiding this comment

✅ EuiCard beta badge

cchaos left a comment

Choose a reason for hiding this comment

✅ [EuiPageContent] panelPaddingSize

cchaos left a comment

Choose a reason for hiding this comment

✅ EuiButtonIcon subdued

kibanamachine commented Oct 27, 2021

thompsongl commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

kibanamachine commented Oct 28, 2021

cchaos left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 28, 2021

thompsongl commented Oct 29, 2021

thompsongl commented Oct 26, 2021 •

edited

Loading

cchaos left a comment •

edited

Loading