[EuiDataGrid] Fix large density not increasing font size on Amsterdam theme #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
elizabetdev
reviewed
Oct 26, 2021
elizabetdev
approved these changes
Oct 26, 2021
|
Oh shoot, @miukimiu's right. Sorry @constancecchen I gave you bad intel. I do think jumping from 16px to 18 is a bit drastic though, so I'd recommend applying the change in teh Amsterdam overrides like she suggested. Sorry |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5320/ |
elizabetdev
approved these changes
Oct 27, 2021
|
Wahoo! Thanks y'all for learning me some theming differences! |
ym
pushed a commit
to ym/eui
that referenced
this pull request
Oct 29, 2021
… theme (elastic#5320) * Fix large density not increasing in fontSize on Amsterdam theme * Add changelog entry * Switch to Amsterdam override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
euiFontSizeis 14px on Amsterdam but 16px on legacy - we should specifyeuiFontSizeMif we want a 16px font size on expanded density data grids.Before
before.mp4
After
after.mp4
Checklist
- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes