-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Fix sorting console errors + header cell focus cleanup/refactors #5209
Merged
cee-chen
merged 12 commits into
elastic:master
from
cee-chen:datagrid-header-cell-wrapper-refactors
Sep 27, 2021
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6be8f53
[Fix] Fix console error when dragging to reorder columns
cee-chen ac5e058
[Fix] DRY out enableInteractives call
cee-chen 5cdd043
[Refactor] Remove unnecessary useEffect dependencies
cee-chen ce98765
[Refactor] Improve focus unit tests
cee-chen 541359a
[Refactor] Move interactive fns to separate/external fns vs. useCallback
cee-chen 2df8152
[Refactor] Combine enable and focus interactives action
cee-chen 7fdef44
[Refactor] More complete multiple interactive children unit tests
cee-chen a6f5c3b
[Refactor] Misc cleanup
cee-chen 405b1c0
[Fix] Remove F2 key event
cee-chen cdb5a42
Add changelog entry
cee-chen b80f2ad
Merge branch 'master' into datagrid-header-cell-wrapper-refactors
cee-chen c042b1d
Update changelog
cee-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, good catch!!