Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pull the latest docker image (node:8) before running the tests in docker #510

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

Crazybus
Copy link
Contributor

By default docker will use whatever image is available locally if the node:8 image already exists. This meant that different versions of npm/node were being run depending on which jenkins worker picked up the job.

docker. By default docker will use whatever image is available locally
if the node:8 image already exists. This meant that different versions
of npm/node were being run depending on which jenkins worker picked up
the job.
@Crazybus Crazybus requested a review from cjcenizal March 16, 2018 10:08
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus Crazybus merged commit 38ab7ca into elastic:master Mar 16, 2018
@Crazybus Crazybus deleted the i_love_docker_tags branch March 16, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants