-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSideNav] EuiSideNavProps default generic value #4802
[EuiSideNav] EuiSideNavProps default generic value #4802
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
Thanks, @rbrishabh! |
Hey @thompsongl! thanks for the quick review! I've added the changelog! |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4802/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4802/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; Thanks, @rbrishabh!
Fixes #4801
Hey @thompsongl! How does this look?
thank you :)