Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Clean up EuiSearchBar docs and reorganize code. (#454)" #470

Merged
merged 9 commits into from
Mar 8, 2018

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Mar 5, 2018

This partially reverts commit 3a910d3, by moving the Query and Ast services back into the components directory.

Things I'm preserving:

  • Change random.oneOf to accept an array.
  • Import components into examples via the root components module.
  • Refactor search bar docs for clearer data flow and render methods.
  • Fix typos in docs.
  • Import Enzyme utilities from enzyme root module in tests.
  • Export Query and Ast services.
  • Use Component instead of React.Component.
  • Rename astToES to astToEs

@cjcenizal cjcenizal force-pushed the revert-query-refactor branch from def84ff to 08b4068 Compare March 5, 2018 18:59
@cjcenizal
Copy link
Contributor Author

@uboness Can you take a quick look at this and let me know if this unblocks you?

@cjcenizal cjcenizal force-pushed the revert-query-refactor branch from c427ecd to 0aed1db Compare March 8, 2018 01:27
@cjcenizal
Copy link
Contributor Author

I'm going to merge this to unblock another PR. Let me know if there's anything else that's blocking you @uboness.

@cjcenizal cjcenizal merged commit 4377f22 into elastic:master Mar 8, 2018
@cjcenizal cjcenizal deleted the revert-query-refactor branch March 8, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant