Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCard] Allow selectable with layout="horizontal" #4692

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 7, 2021

Summary

Allows for selectable EuiCard with layout="horizontal"

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox

- [ ] Added documentation

  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately

- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl requested a review from cchaos April 7, 2021 21:16
@@ -272,4 +272,19 @@ describe('EuiCard', () => {
expect(component).toMatchSnapshot();
});
});

test('horizontal selectable', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Focused on TS changes

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4692/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks so much @thompsongl !!

@thompsongl thompsongl merged commit f62d379 into elastic:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants