-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rk/4648 runtime icon #4650
Rk/4648 runtime icon #4650
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4650/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4650/ |
I honestly find the one on the left (no circle) to be much more discernable than the other. |
Same. I'll make the change! |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4650/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
Closes #4648
Summary
yarn compile-icons
)1. indexRuntime
Template alignment
2. eql
Not intentional change here. The
yarn compile-icons
step picked up some changes on theeql
glyph, so they're included here. It initially messed up a path, so I copied the SVG element from the current, live docs site.Checklist
- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox~- [ ] Props have proper autodocs and playground toggles
- [ ] Checked Code Sandbox works for the any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes