Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rk/4648 runtime icon #4650

Merged
merged 5 commits into from
Mar 18, 2021
Merged

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Mar 17, 2021

Closes #4648

Summary

  1. Adds runtime icon.
  2. Updates eql (picked up via yarn compile-icons)

1. indexRuntime

Screen Shot 2021-03-18 at 9 12 35 AM

Screen Shot 2021-03-18 at 9 12 26 AM

Template alignment

Screen Shot 2021-03-18 at 9 16 04 AM


2. eql

Not intentional change here. The yarn compile-icons step picked up some changes on the eql glyph, so they're included here. It initially messed up a path, so I copied the SVG element from the current, live docs site.

Screen Shot 2021-03-18 at 8 11 11 AM

Screen Shot 2021-03-18 at 8 11 03 AM

Checklist

  • Check against all themes for compatibility in both light and dark modes
    - [ ] Checked in mobile
    - [ ] Checked in Chrome, Safari, Edge, and Firefox
    ~- [ ] Props have proper autodocs and playground toggles
  • Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4650/

@ryankeairns ryankeairns marked this pull request as ready for review March 18, 2021 13:19
@ryankeairns
Copy link
Contributor Author

Here's a side-by-side view with an alternative design - no circle, just the play/triangle:

200%

Screen Shot 2021-03-18 at 8 34 55 AM

100% (actual)

Screen Shot 2021-03-18 at 8 35 13 AM

@ryankeairns ryankeairns requested a review from cchaos March 18, 2021 13:37
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4650/

@cchaos
Copy link
Contributor

cchaos commented Mar 18, 2021

I honestly find the one on the left (no circle) to be much more discernable than the other.

@ryankeairns
Copy link
Contributor Author

I honestly find the one on the left (no circle) to be much more discernable than the other.

Same. I'll make the change!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4650/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@ryankeairns ryankeairns merged commit a94cbd3 into elastic:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiIcon] Add glyph to denote a runtime field
3 participants