Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background to data grid content. Add more params to euiScrollBar #4509

Merged
merged 6 commits into from
Feb 11, 2021

Conversation

snide
Copy link
Contributor

@snide snide commented Feb 10, 2021

Summary

  • Adds a background to EuiDataGrid content. This is helpful for when it is in virutalized mode.
  • Added two params to mixin euiScrollBar to allow for customizing coloring.
  • Removed the SCROLLBAR_HEIGHT as a factor in sizing height. As far as I can tell in FF/Chrome, this was adding unnecessary height.

After

image

image

Before

image

I will consult with @cchaos later today for some styling feedback.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/

@snide snide requested a review from chandlerprall February 11, 2021 17:46
@snide
Copy link
Contributor Author

snide commented Feb 11, 2021

@chandlerprall This is a pretty simple one, but can you please verify that removing the scrollbar height is ok? I couldn't find any usage where it needed to be part of the calculation. It looked like it was extraneous.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Love that scrollbar height going away, confirmed it isn't needed anymore.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/

@chandlerprall chandlerprall merged commit 0786765 into elastic:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants