-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background to data grid content. Add more params to euiScrollBar #4509
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/ |
@chandlerprall This is a pretty simple one, but can you please verify that removing the scrollbar height is ok? I couldn't find any usage where it needed to be part of the calculation. It looked like it was extraneous. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! Love that scrollbar height going away, confirmed it isn't needed anymore.
Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4509/ |
Summary
EuiDataGrid
content. This is helpful for when it is in virutalized mode.mixin euiScrollBar
to allow for customizing coloring.After
Before
I will consult with @cchaos later today for some styling feedback.
Checklist
[ ] Props have proper autodocs and playground togglesChecked Code Sandbox works for the any docs examplesAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes